[HOLD for payment 2023-09-18] [$1000] Web - Thread - No space between message and compose box when sender leave thread

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. send any message and click on reply in thread option
3. send message in thread
4. from receiver side go to thread
5. from sender side leave thread

Expected Result:

Should be some space between message and compose box

Actual Result:

No space between message and compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-08.at.5.29.13.PM.mov

Recording.5908.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

**Slack conversation:**https://expensify.slack.com/archives/C049HHMV9SM/p1691496184324319

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01007c19ea2483982e
• Upwork Job ID: 1696437995377553408
• Last Price Increase: 2023-08-29

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No margin/padding between last message and composer when sender leaves thread

What is the root cause of that problem?

We are not rerendering the ReportActionsView on particinpants change, that won't rerenders ReportActionsList which is responsible for adding the bottom padding if required when we are not showing the RecipientLocalTime. That is causing this issue and not adding bottom padding dynamically.

App/src/pages/home/report/ReportActionsList.js

Line 166 in d449072

<Animated.View style={[animatedStyles, styles.flex1, !shouldShowReportRecipientLocalTime && !hideComposer ? styles.pb4 : {}]}>

What changes do you think we should make in order to solve the problem?

We need to add a check either for participantAccountIDs or participants length within arePropsEqual function here. That will rerender the component if the lengths are not same and allow the bottom padding if needed.

App/src/pages/home/report/ReportActionsView.js

Line 379 in d449072

function arePropsEqual(oldProps, newProps) {

[ShogunFire]

I don't see the pusher message in the console but something seems weird, when I put a breakpoint, one of the participant of the parent report is removed but not the thread report. I believe this one is backend

[melvin-bot]

@slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[slafortune]

I'll get some engineering eyes

When the other person left the thread we are not showing the timestamp, in this case we need to provide some space/gap between last message and composer. Currently last message and composer don’t have any gap for this scenario.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Gonals]

Sure. @shawnborton, any preference on the size of that space? 😁

[Pujan92]

Just sharing the issue screenshot

[shawnborton]

We should take a consistent look at this everywhere, not just threads.

I think a good rule would be that if there is no timezone information, there should always be 8px of margin above the compose box.

If there is a timezone information, we should display 8px of margin above and below the timezone.

And this should be the case for all chats as a consistent, global style - not specific to threads or group chats or anything like that.

[Pujan92]

We already have the logic for that(show space when timezone isn't been shown) but specific to this scenario we are not rerendering the component when participants get updated. Showing timezone depends on that factor too. cc: @Gonals

[Gonals]

Given the info, marking this as external!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01007c19ea2483982e

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Thread - No space between message and compose box when sender leave thread

What is the root cause of that problem?

In here

App/src/pages/home/report/ReportActionsList.js

Line 290 in 7d1f5c6

<Animated.View style={[animatedStyles, styles.flex1, !shouldShowReportRecipientLocalTime && !hideComposer ? styles.pb4 : {}]}>

We already have the logic to add paddingBottom: 8px, shouldShowReportRecipientLocalTime is calculated base on report.participantAccountIDs.

When users leave the thread, the report.participantAccountIDs is updated but in ReportActionsView we don't have the logic to re-render if report.participantAccountIDs gets changed

App/src/pages/home/report/ReportActionsView.js

Line 201 in 7d1f5c6

function arePropsEqual(oldProps, newProps) {

That why at that time shouldShowReportRecipientLocalTime is still true (that should be false)

What changes do you think we should make in order to solve the problem?

We shouldn't check shouldShowReportRecipientLocalTime or hideComposer in ReportActionsList. This logic should be added in ReportActionCompose.

In ReportActionCompose we already have shouldShowReportRecipientLocalTime so we just need to move hideComposer from ReportsActionList to ReportActionCompose and delete shouldShowReportRecipientLocalTime in ReportsActionList

If we do that, we don't need to re-render the ReportActionsList if report.participantAccountIDs gets changed

    const isSendDisabled = isCommentEmpty || isBlockedFromConcierge || disabled || hasExceededMaxCommentLength;
    const hideComposer = ReportUtils.shouldDisableWriteActions(report); // add this line

    return (
        <View
            ref={containerRef}
            style={[shouldShowReportRecipientLocalTime && !lodashGet(network, 'isOffline') && styles.chatItemComposeWithFirstRow, isComposerFullSize && styles.chatItemFullComposeRow,
            !shouldShowReportRecipientLocalTime && !hideComposer ? styles.pt4 : {} // add this line
        ]}

[jjcoffee]

Sorry got caught up in higher priority reviews today, will review the proposals tomorrow!

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jjcoffee]

PR merged!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.67-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Thread - No space between message and compose box when sender leave thread #26770

If no regressions arise, payment will be issued on 2023-09-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment
• @jjcoffee requires payment
• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@jjcoffee friendly reminder on the checklist so that we can pay on Monday.

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - padding was already there, the component just wasn't re-rendering.
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1694701144755569
• Determine if we should create a regression test for this bug. I don't think this is impactful enough to need a regression test
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[melvin-bot]

@puneetlath, @Pujan92, @Gonals, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Gonals]

I think we are all done here, right?

[puneetlath]

Just need to pay. @Pujan92 @gadhiyamanan can you apply to the job? https://www.upwork.com/jobs/~01007c19ea2483982e

[gadhiyamanan]

@puneetlath applied, thanks!

[Pujan92]

Applied :)

[puneetlath]

All paid. Thanks everyone!