Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing out yields strange SignIn Screen URL Format #2620

Closed
jasperhuangg opened this issue Apr 29, 2021 · 3 comments
Closed

Signing out yields strange SignIn Screen URL Format #2620

jasperhuangg opened this issue Apr 29, 2021 · 3 comments
Labels

Comments

@jasperhuangg
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Signing out should navigate back to [baseURL]/

Actual Result:

Signing out navigates to [baseURL]/?params=%5Bobject%20Object%5D&screen=Report

Action Performed:

  1. Sign in to your account on Web or Mobile Web.
  2. Take a few actions (open different chats, etc.)
  3. Sign out.
  4. Observe the URL format.

Workaround:

Yep, it just looks pretty ugly.

Platform:

All platforms, but the URL is only visible on Web and Mobile Web.

Web
Mobile Web

Version Number: v1.0.33-0

cc @marcaaron

@jasperhuangg jasperhuangg added the DeployBlockerCash This issue or pull request should block deployment label Apr 29, 2021
@jasperhuangg jasperhuangg removed the DeployBlockerCash This issue or pull request should block deployment label Apr 29, 2021
@jasperhuangg jasperhuangg reopened this Apr 29, 2021
@jasperhuangg jasperhuangg added the DeployBlockerCash This issue or pull request should block deployment label Apr 29, 2021
@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label Apr 29, 2021
@roryabraham
Copy link
Contributor

@isagoico since there are no known side-effects of these strange URLs, I'm removing the deploy blocker label from this, and making it a weekly.

@roryabraham roryabraham added the Weekly KSv2 label Apr 29, 2021
@marcaaron
Copy link
Contributor

@jasperhuangg What's the status on this?

@jasperhuangg
Copy link
Contributor Author

jasperhuangg commented May 6, 2021

Oop, sorry I forgot I created this issue; it should have been fixed by #2616. The PR is on staging, and I just tested it. Closing this!

@marcaaron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants