Changing currency closes the request Modal

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any workspace chat.
2. Open Request money page from + button.
3. On the amount page, click currency.
4. Notice that search is not auto focused.
5. Find a currency and select it.
6. Observe that whole page is closed.

Expected Result:

User should be able to select the currency and search field on currency selection page should be auto-focused,

Actual Result:

Selecting currency on currency selection page, closes the whole page.
Also, the search field is not auto-focused on currency selection page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-18.at.8.40.57.PM.mov

Recording.1532.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692371427006799

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[garrettmknight]

Confirmed.

[garrettmknight]

Regression of #25386

[payal-lathidadiya]

@parasharrajat I couldn't really reproduce, Is there any specific step I'm missing?

[garrettmknight]

I was able to reproduce - check the video to see if there's a step that looks like you're missing it.

[parasharrajat]

Yeah, that one step might be that you need a few beta to be enabled for this (Check the tabs on request page).

[payal-lathidadiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The search field is not auto-focused on currency selection page.

What is the root cause of that problem?

When search value is empty, the expression here evaluates isEmpty as "" (string) instead of boolean.

What changes do you think we should make in order to solve the problem?

In IOSCurrencySelection component, change expression as below to correctly evaluate isEmpty as boolean instead of string

const isEmpty = searchValue.trim().length && !filteredCurrencies.length;

What alternative solutions did you explore? (Optional)

None

[parasharrajat]

@payal-lathidadiya Your proposal neither explains the root cause nor the solution on how it solves it.

The search field is not auto-focused on currency selection page.

This is not expected behaviour.

[payal-lathidadiya]

@payal-lathidadiya Your proposal neither explains the root cause nor the solution on how it solves it.

The search field is not auto-focused on currency selection page.

This is not expected behaviour.

Ops! understood.
Thanks @parasharrajat for your review.

Something is really weird while debugging route navigation stacks. At times, I could find it working correctly at intermediate steps and proposed changes. 😬

This is definitely not the correct RCA.

I'll dig into further analysis to get more insights on navigation updates.

[mountiny]

dupe of #25626