[$1000] Web - Two users requesting money to each other at the same time at the same time causes console error and the second user lefts untested in the request room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open User A and User B on different tabs
2. Make sure there is no unpaid request between user A and User B
3. Click on the "+" from both user A nd user B
4. Click on request money from both user A and user B
5. Input different amount(one greater than the other) for both User A and User B
6. When the list to choose user from opens for both user A and user B, for user A choose user B and for user B choose user A
7. Request money from both user A and user B simultaneously
8. Observe the chat room when it opens the second user name will disappear after a while

Expected Result:

Request money will appear calculating the amount that will be left to be paid with one of the users

Actual Result:

Requested amount will cause one of the second users to disappear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

request.money.second.user.disappears.mp4

Recording.4072.mp4

Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693385547687049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0180129a6e4cab1ea2
• Upwork Job ID: 1705141269262184448
• Last Price Increase: 2023-11-22

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MariaHCD]

At first glance, I don't think this is a deploy blocker. It's likely a race condition. From the videos, I do see that the IOU requests are being created correctly in the backend but the App isn't displaying them correctly? Or perhaps the API is not sending the correct data.

[MariaHCD]

Ran out of time today but I don't think this should block the deploy so I can take a closer look tomorrow.

[luacmartins]

Agree this is NAB.

[MariaHCD]

Looks like there might be an issue with handling amounts when users edit money requests as well: https://expensify.slack.com/archives/C057F53HR40/p1693480256076329?thread_ts=1693427344.974909&cid=C057F53HR40

Might have the same root cause as this one.

[MariaHCD]

We've recently deployed some changes around computing the IOU owner as part of this internal backend PR: https://github.com/Expensify/Auth/pull/8605

@lidiyakelay Can we retest this and see if the issue still persists?

[lidiyakelay]

@MariaHCD I have been able to reproduce the issue on the latest version as well

update.on.requesting.money.semuntaneously.mp4

[MariaHCD]

Thanks, @lidiyakelay! I'll take another look at this.

[MariaHCD]

Didn't get a chance to look into this just yet.

[MariaHCD]

No updates just yet. Will look asap.

[MariaHCD]

Focused on other priorities, getting to this asap.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[muttmuure]

Should we take this internal @MariaHCD?

[MariaHCD]

I think we should but I honestly don't have the bandwidth to investigate this right now since I'm focusing on #wave8 😅

[MariaHCD]

Downgrading the priority for now. We shouldn't encounter this too often but it's still worth investigating and fixing.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MariaHCD]

Taking this internal for the time being.

[melvin-bot]

Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MariaHCD]

Focusing on some higher priority issues, will aim to get to this asap.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[muttmuure]

Since this is no longer reproducible I'm going to close it.