Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - Copy pasting automatic selected timezone shows no result (tested with Aisa/Calcutta) #26400

Closed
1 of 6 tasks
izarutskaya opened this issue Aug 31, 2023 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open settings->profile->timezone
  3. Unselect 'Automatically determine location'
  4. Open timezone
  5. Copy the timezone
  6. Empty the search and paste, observe that no results are displayed

Expected Result:

App should display results according to search

Actual Result:

App displays no results if we copy automatic detected location, empty search and paste to search the location

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.60-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

no.results.on.copy.paste.timezone.mp4
Recording.1405.mp4

Expensify/Expensify Issue URL:

Issue reported by: @@dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692721456621009

View all open jobs on GitHub

@GItGudRatio
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

This is a case where the timezone Asia/Calcutta is not shown.

What is the root cause of that problem?

This issue does not have anything to do with the copy pasting mechanism, rather the timezone "Asia/Calcutta" is missing from the list of timezones in TIMEZONES.js, which makes it such that the timezone is simply not present in the list.

What changes do you think we should make in order to solve the problem?

Firstly, we should add Asia/Calcutta to the timezone array.

Next, to solve this on a broader level, we need to synchronize the list of timezones used on the backend that automatically select the timezone and the list of available timezones on the frontend.

What alternative solutions did you explore? (Optional)

N/A

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@bernhardoj
Copy link
Contributor

We already have Asia/Kolkata which is the new name for Calcutta in the timezone list.

'Asia/Kolkata',

We are currently using moment to guess the user timezone (which returns the old name) but it will be replaced in this PR. I don't know how accurate it will be with the new approach, but I guess we can hold this one until the mentioned PR is resolved.

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@maddylewis
Copy link
Contributor

holding for - #26248

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@maddylewis maddylewis added Weekly KSv2 and removed Daily KSv2 labels Sep 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2023
@maddylewis
Copy link
Contributor

ok this is merged - #26248

let's see if i can repro now.

@melvin-bot melvin-bot bot removed the Overdue label Sep 13, 2023
@maddylewis maddylewis added Daily KSv2 and removed Weekly KSv2 labels Sep 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 14, 2023

@maddylewis this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@maddylewis
Copy link
Contributor

will test today!

@maddylewis
Copy link
Contributor

neither of the unexpected behaviors mentioned on this issue are occurring now. i think we're good to close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants