Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-09-01 #26539

Closed
40 tasks done
OSBotify opened this issue Sep 1, 2023 · 19 comments
Closed
40 tasks done

Deploy Checklist: New Expensify 2023-09-01 #26539

OSBotify opened this issue Sep 1, 2023 · 19 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2023

Release Version: 1.3.62-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 2, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Sep 2, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.62-1 🚀

@mountiny mountiny self-assigned this Sep 3, 2023
@mountiny mountiny added the Daily KSv2 label Sep 3, 2023
@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Gonna take this one on 🚀 Seems like regression testing is done, waiting for the summary

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #26586 off as its fixed in staging

@kavimuru
Copy link

kavimuru commented Sep 3, 2023

@mountiny
Regression almost completed except CP

Open blockers:
#26558
#26585
#26588

PR #25707 failing with:
#26585 (also a blocker)
#26559
#26560 (repro in prod)

PR #25980 failing with #26589 (repro in prod) - can we check it off?
PR #26155 failing with #26590 (repro in prod) - can we check it off?
PR #26365 failing with #26034 (repro in prod) - can we check it off?
PR #26500 failing with comment here - can we check it off?

PR #26520 failing with:
#26586
#26587
#26588 (also a blocker)

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

#26588 resolved in staging

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #26284 (comment) off, QA passed

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #26520 off, all linked issues are resolved

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #25980 off, I dont think the linked issue should be a blocker.

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #26155 off, issue is repro in production and lower priority

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #26365 off, the issue is repro in prod

#26500 also checked off, the console error should not be a problem

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #26355 off, simple update of the help doc

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2023

Checking #26064 off as the QA is a bit more complicated but its a low priority

@mvtglobally
Copy link

CPs are checked off

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2023

Checking #26559 off it was demoted from a blocker

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2023

Checking #26558 off, it was demoted because its behind beta

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2023

Checking #25707 off as all the realted issues been resolved or demoted

@mvtglobally
Copy link

@mountin CP is pass Validating images

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2023

image

No significant crashes

And graphs looking good too

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2023

:shipit:

@mountiny mountiny closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants