Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-09-13] Feature Request: [distance] request show address suggestions by place name or address #26688

Closed
neil-marcellini opened this issue Sep 4, 2023 · 4 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@neil-marcellini
Copy link
Contributor

Problem

Autocomplete suggestions are only shown for addresses when entering a waypoint for a distance request. So if I want to go the the Expensify lounge in SF I need to know the address 88 Kearny in order to see a suggestion for the full address. Instead I want to be able to enter “Expensify lounge SF” and see it show up as a suggestion. We still want suggestions for addresses as well.

Solution

We can make the work by changing the types query param to allow all place types rather than only addresses.

@neil-marcellini neil-marcellini self-assigned this Sep 4, 2023
@neil-marcellini neil-marcellini added Daily KSv2 NewFeature Something to build that is a new item. labels Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 4, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 4, 2023
@melvin-bot melvin-bot bot changed the title Feature Request: [distance] request show address suggestions by place name or address [HOLD for payment 2023-09-13] Feature Request: [distance] request show address suggestions by place name or address Sep 6, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.64-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 13, 2023
@sakluger
Copy link
Contributor

Nobody needs to be paid for this one, closing!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants