Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment issue for E/App PR#26739 #26740

Closed
melvin-bot bot opened this issue Sep 5, 2023 · 19 comments
Closed

Payment issue for E/App PR#26739 #26740

melvin-bot bot opened this issue Sep 5, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Issue created to compensate the Contributor+ member for their work on #26739
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @mananjadhav.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017a8f3253d4b474a8
  • Upwork Job ID: 1698888624054550528
  • Last Price Increase: 2023-09-05
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Sep 5, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Sep 5, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 5, 2023

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017a8f3253d4b474a8

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 5, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 5, 2023

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

@mananjadhav
Copy link
Collaborator

@Beamanator I couldn't figure out if this is deployed to production based on the PR comments. Can you help update the payout date here? along with the Payout amount?

@Beamanator
Copy link
Contributor

I believe it was first deployed to prod on Sept 7 👍

I know @JmillsExpensify was also very busy last week during some conferences, I'm sure he'll be back soon to close this out & help figure out payment 🙏

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Daily KSv2 labels Sep 11, 2023
@JmillsExpensify
Copy link

Working on this now.

@melvin-bot melvin-bot bot removed the Overdue label Sep 13, 2023
@JmillsExpensify
Copy link

Payment summary: @mananjadhav $500. Approved for payment via NewDot.

@mananjadhav
Copy link
Collaborator

mananjadhav commented Sep 17, 2023

@JmillsExpensify I don't see the payment approved on the NewDot? I've raised this now. Let me know if you think this is a duplicate request.

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 19, 2023

@JmillsExpensify @mananjadhav this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2023
@JmillsExpensify
Copy link

@JmillsExpensify I don't see the payment approved on the NewDot? I've raised this now. Let me know if you think this is a duplicate request.

All done.

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2023
@mananjadhav
Copy link
Collaborator

@JmillsExpensify Should we close this as the payout is approved?

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 26, 2023

@JmillsExpensify @mananjadhav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 28, 2023

@JmillsExpensify, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 2, 2023

@JmillsExpensify, @mananjadhav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@mananjadhav
Copy link
Collaborator

@JmillsExpensify I think we can close this one out?

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 3, 2023

@JmillsExpensify @mananjadhav this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 6, 2023

@JmillsExpensify, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 10, 2023

@JmillsExpensify, @mananjadhav Still overdue 6 days?! Let's take care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants