-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #26945
Comments
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.IOU amount is autofilled and displayed in manual request page when editing Distance request. What is the root cause of that problem?The What changes do you think we should make in order to solve the problem?Solution 1 -amount={iou.amount}
+amount={isEditing ? iou.amount : 0} Solution 2 Solution 3 What alternative solutions did you explore? (Optional)None. |
ProposalPlease re-state the problem that we are trying to solve in this issue.When we go to the manual money request tab after starting a distance request, the amount from the distance request remains. What is the root cause of that problem?We already reset the data when the tab changes: App/src/pages/iou/MoneyRequestSelectorPage.js Lines 64 to 67 in f67bf9f
The problem is that when the manual data tab renders, the new amount value has not yet been reset in Onyx. When it is reset, we do not change the amount since there is a condition returning early if App/src/pages/iou/steps/MoneyRequestAmountForm.js Lines 103 to 105 in f67bf9f
What changes do you think we should make in order to solve the problem?I suggest we update the aforementioned condition so that we still set the amount if it is 0:
What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Demo of my proposed solution: Screen.Recording.2023-09-07.at.13.59.52.mov |
Also as per this comment we want to clear the data when we switch between request types: #26579 (comment)
|
I've run out of time today and will test soon. |
Still on my testing list |
Job added to Upwork: https://www.upwork.com/jobs/~01baf90b8cc8571594 |
Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 ( |
@cubuspl42 - when you get a chance, can you please review if the proposals will address this issue? Thanks! |
ProposalPlease re-state the problem that we are trying to solve in this issue.The Distance IOU amount is auto-filled and displayed in manual request money page. What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)Another way for |
I think that the "expected result" should not be just the "actual result", but negated. What amount should actually be displayed? 0? |
Yeah, I think 0 makes sense. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-09. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-10. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@cubuspl42 - to prepare for the payment date, can you please complete the checklist? Thanks! |
|
My mistake, I missed that there was a regression here but was addressed quickly. I need another day to review and confirm the payment amounts. For now, I've paid the reporter. |
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~01baf90b8cc8571594 *If applicable, the bonuses will be applied on the final payment Extra Notes regarding payment: This GH would fall under an urgency bonus but due to regression there won't be one. We did fix the issue quickly, so I'll be keeping the base pay as is for the contributors. |
Everyone has been paid in Upwork. I need to create the regression test and will close it. |
@cubuspl42, @marcochavezf, @alexpensify, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue, I need to create the regression test. |
It's the opposite, but doesn't matter much I guess |
Alright, I updated the summary based on the @cubuspl42 feedback Also, I created the regression test, so I'm going to close this out. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The Distance IOU amount should not be displayed in manual request money page.
Actual Result:
The Distance IOU amount is auto-filled and displayed in manual request money page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6191091_manual.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693999827026719
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: