Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] IPAD - LHN is missing in IPAD #27086

Closed
1 of 7 tasks
kbecciv opened this issue Sep 9, 2023 · 27 comments
Closed
1 of 7 tasks

[$1000] IPAD - LHN is missing in IPAD #27086

kbecciv opened this issue Sep 9, 2023 · 27 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Sep 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign in to new expensify app on an iPad

Expected Result:

Able to use NewDot in IPAD

Actual Result:

LHN is missing in IPAD

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
  • IOS / IPAD

Version Number: 1.3.66-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1693878600.2.MP4
IMG_0791.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @aswin-s
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693878764944479

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014f2b5dc76517b53d
  • Upwork Job ID: 1701289201178431488
  • Last Price Increase: 2023-09-25
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 9, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv
Copy link
Author

kbecciv commented Sep 9, 2023

QA team is able to reproduce it on modal: iPad Pro11 2nd gen/iPadOS 15.7

@zanyrenney
Copy link
Contributor

Thanks! I don't have an iPad nor can I test this on Browserstack, so going to add the external label to move this forward.

@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label Sep 11, 2023
@melvin-bot melvin-bot bot changed the title IPAD - LHN is missing in IPAD [$500] IPAD - LHN is missing in IPAD Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~014f2b5dc76517b53d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

@zanyrenney, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@zanyrenney
Copy link
Contributor

@aimane-chnaif what's the latest here? have you been able to test this on iPad?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 15, 2023
@zanyrenney
Copy link
Contributor

bump @aimane-chnaif ?

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2023
@aimane-chnaif
Copy link
Contributor

We temporarily fixed orientation to portrait and forced all screen view to small screen size (programmatically) for appstore approval.
I think we should still fix broken layout on medium screen which is iPad, tablet's original size.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 20, 2023
@zanyrenney
Copy link
Contributor

@aimane-chnaif should we adjust the bounty here do you think?

@melvin-bot
Copy link

melvin-bot bot commented Sep 23, 2023

@zanyrenney @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2023
@zanyrenney zanyrenney changed the title [$500] IPAD - LHN is missing in IPAD [$1000] IPAD - LHN is missing in IPAD Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

Upwork job price has been updated to $1000

@zanyrenney
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@aimane-chnaif
Copy link
Contributor

This should be already fixed as we have disabled landscape configuration here #27016

@shubham1206agra it was temporary workaround for appstore approval.
We should still allow medium screen size what iPad has and fix broken layout.

@studentofcoding
Copy link
Contributor

Can you share which iPad specifically we have this problem with? And I believe this is on Native Apps right? And not Dekstop app

@aimane-chnaif
Copy link
Contributor

Can you share which iPad specifically we have this problem with? And I believe this is on Native Apps right? And not Dekstop app

All iPads. Also all android tablets

@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2023
@zanyrenney
Copy link
Contributor

Thanks. @aimane-chnaif what do we need to do to move ahead here?

@melvin-bot melvin-bot bot removed the Overdue label Sep 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2023

@zanyrenney @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@zanyrenney
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@zanyrenney
Copy link
Contributor

CLosing - as not supporting IPAD bugs - #26421 (comment)

@Julesssss
Copy link
Contributor

I fully support dropping iPad support, but we should officially drop iPad support in the AppStore in that case to prevent downloads, as the app looks horrendous and is totally unusable.

@Julesssss
Copy link
Contributor

WOW. Apple won't let us drop iPad support. This is going to cause us problems in the future, as they have already held releases due to broken iPad functionality...

@aimane-chnaif
Copy link
Contributor

I suggest to enable landscape again (temporarily disabled in #27004) and let react-navigation experts (i.e. @adamgrzybowski) fix broken layout.

@Julesssss
Copy link
Contributor

Started a Slack discussion here, as I don't think we can simply drop iPad support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants