[HOLD for payment 2023-09-21] [HOLD for payment 2023-09-20] Web - Bank account - App crashes when checking ToS checkbox and Continue CTA is not working

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Workspace > any workspace > Bank account.
3. Click Add manually.
4. Enter routing number and account number.
5. Check the terms of service checkbox.
6. Refresh the page.
7. Return to the page in Step 5.
8. Click Continue

Expected Result:

In Step 5, app does not crash.
In Step 8, user is brought to the next step.

Actual Result:

In Step 5, app crashes.
In Step 8, Continue button is not responsive.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.68-12

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6197284_20230912_143632.mp4

utest-dl.s3.amazonaws.com_12102_26469_428866_6197284_bugAttachment_Bug6197284_staging.new.expensify.com-1694507081970.log_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20230912T111516Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Am.txt

Expensify/Expensify Issue URL:

Issue reported by: @tewodrosGirmaA

Slack conversation: (https://expensify.slack.com/archives/C049HHMV9SM/p1694492106740469)

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

it's being addressed here, I believe #27217
cc @techievivek

[techievivek]

This was reported by @hungvu193 here https://github.com/Expensify/App/pull/26140#discussion_r1322344633

[techievivek]

@hungvu193 Did you make a bug proposal on Slack so we can issue the reporting bounty?

[trjExpensify]

Okay, so order of priority.. we have a PR up to fix this regression, yeah? @techievivek shall I switch you out for @madmax330?

[hungvu193]

@hungvu193 Did you make a bug proposal on Slack so we can issue the reporting bounty?

just checked, I think @tewodrosGirmaA reported it first.

[tewodrosGirmaA]

@hungvu193 Did you make a bug proposal on Slack so we can issue the reporting bounty?

just checked, I think @tewodrosGirmaA reported it first.

Thank you @hungvu193 , I think Katerina updated

[trjExpensify]

This has been fixed, once it hits prod, I'll pay out the bug report of $50 to @tewodrosGirmaA.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Return early if the value is empty or non-string #27217

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@techievivek] The PR that introduced the bug has been identified. Link to the PR:
• [@techievivek] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@techievivek] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@techievivek] Determine if we should create a regression test for this bug.
• [@techievivek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

This is on prod now. @tewodrosGirmaA I've sent you an offer for the bug report. 👍

[trjExpensify]

Settled up!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Return early if the value is empty or non-string #27217

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@techievivek] The PR that introduced the bug has been identified. Link to the PR:
• [@techievivek] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@techievivek] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@techievivek] Determine if we should create a regression test for this bug.
• [@techievivek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: