[$500] [HOLD for payment 2023-09-21] [HOLD for payment 2023-09-20] mWeb-LHN- Site crashes while interacting with Pinned and mark as unread menu options

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Long press any report to "mark as unread" or "Pin" in LHN
3. Long press any report and attempt to close it by tapping outside the menu
4. Long press already pinned report
5. Long press bold unread report

Expected Result:

The user must be able to to "mark as unread" or "Pin" the report in the LHN.
Long press any report and attempt to close it by tapping outside the menu, must not crash the site and menu alone must be closed.
When user long press the already pinned report, it must show unpin option in the menu.
When user long press the bold unread report, it must show" Mark as read" option in the menu.

Actual Result:

Marking conversation in LHN as Pinned and mark us read crashes the site
When user, Long press any report and attempt to close it by tapping outside the menu, the web page crashes.
When user long press the already pinned report, it again shows pin option in the menu.
When user long press the bold unread report, it again shows " Mark as unread" option in the menu.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.68-9

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6197390_crash.mp4

Bug6197390_lhn.mp4

utest-dl.s3.amazonaws.com_12102_26469_428866_6197390_bugAttachment_Bug6197390_crash.txt_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20230912T114336Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Amz-Credential=AKIAJ2UIWMJ2OMC3UCQQ%.txt

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0108bdcafaa9f38eb5
• Upwork Job ID: 1709684762519789568
• Last Price Increase: 2023-10-04
• Automatic offers:
• jjcoffee | Reviewer | 27027064
• dukenv0307 | Contributor | 27027065

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pluto0104]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The application crashes when attempting to open the context menu using an LHN row.

What is the root cause of that problem?

This is a regression of #26741.
It's crucial to treat this as a deploy blocker since it doesn't occur on NewDot. The problem lies in how we're passing parameters to the showContextMenu function in the OptionRowLHN file.

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 118 to 132 in 52c54f4

	ReportActionContextMenu.showContextMenu(
	ContextMenuActions.CONTEXT_MENU_TYPES.REPORT,
	event,
	'',
	popoverAnchor,
	props.reportID,
	{},
	'',
	() => {},
	() => setIsContextMenuActive(false),
	false,
	false,
	optionItem.isPinned,
	optionItem.isUnread,
	);

App/src/pages/home/report/ContextMenu/ReportActionContextMenu.js

Lines 52 to 67 in 017c714

	function showContextMenu(
	type,
	event,
	selection,
	contextMenuAnchor,
	reportID = '0',
	reportActionID = '0',
	originalReportID = '0',
	draftMessage = '',
	onShow = () => {},
	onHide = () => {},
	isArchivedRoom = false,
	isChronosReport = false,
	isPinnedChat = false,
	isUnreadChat = false,
	) {

What changes do you think we should make in order to solve the problem?

We need to ensure that the default parameter is correctly passed to the showContextMenu function. Here's the adjusted code:

ReportActionContextMenu.showContextMenu(
  ContextMenuActions.CONTEXT_MENU_TYPES.REPORT,
  event,
  "",
  popoverAnchor,
  props.reportID,
  "",
  "",
  "",
  () => {},
  () => setIsContextMenuActive(false),
  false,
  false,
  optionItem.isPinned,
  optionItem.isUnread
);

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jjcoffee]

The author of the PR that caused the regression, @dukenv0307 will be raising a PR to fix this.

[dukenv0307]

Yes, please assign me to this issue.

[jjcoffee]

@dukenv0307 You can just go ahead and raise the PR, linking this issue. There's no need to wait as it's a deploy blocker; we just want to push the fix as fast as possible!

[dukenv0307]

@jjcoffee The PR is ready to review.

[francoisl]

Fix tested on staging, removing the DeployBlocker label.

[francoisl]

@johncschuster looks like this is ready for payment.

[melvin-bot]

@francoisl, @johncschuster, @jjcoffee Eep! 4 days overdue now. Issues have feelings too...

[francoisl]

@johncschuster any update on payments?

[johncschuster]

Sorry I missed your bump! Working on payment now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0108bdcafaa9f38eb5

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[johncschuster]

@dukenv0307 and @jjcoffee, can you accept those offers? I'll get payment going right away!

[jjcoffee]

@johncschuster This was a regression from #26741 so no payment due here!

[melvin-bot]

@francoisl, @johncschuster, @jjcoffee, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[johncschuster]

Thank you for calling that out, @jjcoffee!