Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up styles.js #27336

Closed
grgia opened this issue Sep 13, 2023 · 7 comments
Closed

Clean up styles.js #27336

grgia opened this issue Sep 13, 2023 · 7 comments
Assignees
Labels

Comments

@grgia
Copy link
Contributor

grgia commented Sep 13, 2023

Convert the static styles in styles.js into functions that take the current theme as an argument instead of a static import. The default export of styles.js will still be the styles with the defaultTheme provided, so this doesn't break anything.

Remove the need to add dynamic styles manually to providers.

@grgia grgia self-assigned this Sep 13, 2023
@grgia
Copy link
Contributor Author

grgia commented Sep 13, 2023

@chrispader mind updating the description here for your open PR?

@chrispader
Copy link
Contributor

I can't update the issue description because i'm not the issue owner 🥴

@grgia
Copy link
Contributor Author

grgia commented Sep 14, 2023

gotta love github

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 19, 2023

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2023
@chrispader
Copy link
Contributor

@grgia is this done? :)

@grgia
Copy link
Contributor Author

grgia commented Dec 6, 2023

@chrispader should we close?

@chrispader
Copy link
Contributor

yes 👍

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@grgia grgia closed this as completed Jan 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants