Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pay bug reporting bonus & close] Android - Double quotes displayed after 3 dots in notification for invite message #27663

Closed
6 tasks
kbecciv opened this issue Sep 18, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Sep 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app and login with user A on android app
  2. Open the app in any other device and login with user B
  3. Minimize or close android app
  4. From user B, invite user A in any workspace
  5. Observe in notification on user A android device that invite message has double quotes after 3 dots

Expected Result:

App should display 3 dots in the end of notification for large messages

Actual Result:

App displays double quotes after 3 dots in the end of notification for workspace invite message

Workaround:

Uknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230913_103958_One.UI.Home.1.mp4
double.quotes.after.3.dots.notification.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694364092518829

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017598e4fcd86f03ec
  • Upwork Job ID: 1703737109181304832
  • Last Price Increase: 2023-09-18
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 18, 2023
@melvin-bot melvin-bot bot changed the title Android - Double quotes displayed after 3 dots in notification for invite message [$500] Android - Double quotes displayed after 3 dots in notification for invite message Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017598e4fcd86f03ec

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@parasharrajat
Copy link
Member

parasharrajat commented Sep 18, 2023

Note: This is most probably a backend issue. Old ref: #14849

@Julesssss
Copy link
Contributor

Likely a dupe (or same root cause) as this issue: #25982

@Julesssss
Copy link
Contributor

Slightly different issue to #25982. But it's almost certainly due to a large notification payload being stripped away due to size.

@Julesssss
Copy link
Contributor

Julesssss commented Sep 19, 2023

Possibly fixed with this internal PR: https://github.com/Expensify/Web-Expensify/pull/38908

@Julesssss Julesssss added the Reviewing Has a PR in review label Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2023

@Julesssss, @michaelhaxhiu, @kevinksullivan, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Julesssss
Copy link
Contributor

I fixed this here. Please pay out the reported bonus now as we don't need to wait for the regression dudection.

Screenshot_20230927-103021

@Julesssss
Copy link
Contributor

Please close after the report bonus is paid

@Expensify Expensify deleted a comment from melvin-bot bot Sep 27, 2023
@michaelhaxhiu
Copy link
Contributor

I invited @dhanashree-sawant to the job in upwork

@michaelhaxhiu michaelhaxhiu changed the title [$500] Android - Double quotes displayed after 3 dots in notification for invite message [pay bug reporting bonus & close] Android - Double quotes displayed after 3 dots in notification for invite message Sep 27, 2023
@michaelhaxhiu michaelhaxhiu added Awaiting Payment Auto-added when associated PR is deployed to production and removed Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review labels Sep 27, 2023
@michaelhaxhiu
Copy link
Contributor

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants