[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - Pressing CTRL+SHIFT+K opens Send message page with random URL params

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Note: make sure you don't have policy room permission

1. Press CTRL+SHIFT+K shortcut to open the Send message page
2. Observe the URL on the browser address bar

Expected Result:

The URL should show /new without any params (just like when we open it from FAB)

Actual Result:

The URL contains some random params

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-18.at.01.07.11.mov

Recording.4590.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694970567497589

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pluto0104]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - When pressing CTRL+SHIFT+K, the "Send Message" page opens with random URL parameters.

What is the root cause of that problem?

The root cause is from beta feature.

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Line 188 in 6be8fca

Navigation.navigate(ROUTES.NEW_CHAT);

The app works correctly when the beta policy room feature is enabled. However, for normal users, it navigates to "new/chat," which doesn't exist due to the following code:

App/src/pages/NewChatSelectorPage.js

Lines 38 to 59 in 6be8fca

	{Permissions.canUsePolicyRooms(props.betas) ? (
	<OnyxTabNavigator
	id={CONST.TAB.NEW_CHAT_TAB_ID}
	tabBar={({state, navigation, position}) => (
	<TabSelector
	state={state}
	navigation={navigation}
	position={position}
	/>
	)}
	>
	<TopTab.Screen
	name={CONST.TAB.NEW_CHAT}
	component={NewChatPage}
	/>
	<TopTab.Screen
	name={CONST.TAB.NEW_ROOM}
	component={WorkspaceNewRoomPage}
	/>
	</OnyxTabNavigator>
	) : (
	<NewChatPage />

What changes do you think we should make in order to solve the problem?

To address this issue, I propose modifying this code:

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Line 188 in 6be8fca

Navigation.navigate(ROUTES.NEW_CHAT);

Navigation.navigate(Permissions.canUsePolicyRooms(this.props.betas) ? ROUTES.NEW_CHAT : ROUTES.NEW);

// or

Navigation.navigate(ROUTES.NEW);

What alternative solutions did you explore? (Optional)

N/A

[situchan]

@Pluto0104's proposal (2nd solution) looks good to me. This is consistent with navigating from FAB.

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 184 to 186 in 6be8fca

	icon: Expensicons.ChatBubble,
	text: props.translate('sidebarScreen.fabNewChat'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),

[jasperhuangg]

Ah thank you for the proposals guys. I already started work on this before seeing them.

Please only comment on issues that have the Bug and External labels applied if you want your proposals to be reviewed/accepted. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix navigating to new chat page via keyboard shortcut #27719

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment
• @bernhardoj requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix navigating to new chat page via keyboard shortcut #27719

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment
• @bernhardoj requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@jasperhuangg, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@peterdbarkerUK, @jasperhuangg, @situchan Still overdue 6 days?! Let's take care of this!

[peterdbarkerUK]

Double checking what steps to follow in this case (for my own paper trail)

[peterdbarkerUK]

Confirmed that only the reporter gets paid here, I'm sorry. As @jasperhuangg said: Please only comment on issues that have the Bug and External labels applied if you want your proposals to be reviewed/accepted. Thanks!

I made a mistake with the payment, sending it as a bonus tied to this job instead of creating a new one. I've updated the other issue
so I believe there's no further action required, but please reopen if something goes wrong.

[situchan]

@peterdbarkerUK I think C+ payment for PR review is pending. Can you please check?

[peterdbarkerUK]

I made a mistake here, and didn't realise @situchan had reviewed the PR.

@situchan I've sent you an offer, please accept and bump me here when you have!

[situchan]

@peterdbarkerUK accepted. thanks