[HOLD for payment 2024-08-07] [$500] [Expensify Help] Add cache busting to HelpDot files

[marcochavezf]

We're loading the CSS files in the help site without a cache-busting technique, which causes to not load the recent CSS file:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dffa1ca53efd8c82
• Upwork Job ID: 1744435293782720512
• Last Price Increase: 2024-07-13
• Automatic offers:
• getusha | Reviewer | 28089289
• wildan-m | Contributor | 103153018

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[rushatgabhane]

Proposal

Evict cache on every deploy.

site.time is the time when jekyll command is run. (reference)

So we can use it to "version" our css href="/assets/css/styles.css?v={{ site.time }}"

App/docs/_layouts/default.html

Line 9 in 21b3e64

<link rel="stylesheet" href="/assets/css/styles.css">

What do you think?

[roryabraham]

In this thread we are discussing moving from GitHub Pages to Cloudflare Pages, which would provide a mechanism to fix this correctly by cache-busting for all files with something like this

[marcochavezf]

Not overdue, update posted above

[marcochavezf]

Latest update here

[marcochavezf]

Hi @rushatgabhane @roryabraham, now that we have the help site running on Cloudflare pages, do you know if we still need to set up the cache-busting mechanism there?

[roryabraham]

Yes, created a WIP PR: #30877

Just need to know the Cloudflare zone for HelpDot

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[melvin-bot]

📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Docs: Add assets versioning with filter #45653

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @wildan-m requires payment automatic offer (Contributor)
• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[zanyrenney]

payment summary

@wildan-m requires payment automatic offer (Contributor) - paid $500 via upwork
@rushatgabhane requires payment through NewDot Manual Requests - paid as part of larger help site project. CLosing!