[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

kbecciv · 2023-09-30T15:51:25Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Right click or long press any report and click on add reaction
Observe that it does nothing and throws console error: Cannot read properties of undefined (reading 'current')

Expected Result:

App should allow users to open emoji picker for reaction

Actual Result:

App does not allow users to open emoji picker for reaction on right click and click on add reaction and it throws console error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mac.chrome.error.on.opening.emoji.reaction.mov

mac.desktop.native.error.on.opening.emoji.reaction.mov

ios.safari.native.error.on.opening.emoji.reaction.mov

android.native.emoji.picker.console.error.mov

android.chrome.console.error.emoji.picker.mp4

windows.chrome.console.error.emoji.picker.mp4

Recording.4810.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696079858252189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0103f61623015d853c
Upwork Job ID: 1708383767969234944
Last Price Increase: 2023-10-01
Automatic offers:

abdulrahuman5196 | Contributor | 26964631
dhanashree-sawant | Reporter | 26964632
hungvu193 | Contributor | 26982014

OSBotify · 2023-09-30T15:52:52Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-09-30T15:52:55Z

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

hungvu193 · 2023-09-30T16:21:07Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after pressing Icon to open emoji picker

What is the root cause of that problem?

It's regression from this PR
#27221
We forgot to add our contentRef to useImperativeHandle, so we can't access it via contextMenuRef.current.contentRef which caused the crash

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 272 to 281 in 52f0e3c

    
           useImperativeHandle(ref, () => ({ 
        
               showContextMenu, 
        
               hideContextMenu, 
        
               showDeleteModal, 
        
               hideDeleteModal, 
        
               isActiveReportAction, 
        
               instanceID, 
        
               runAndResetOnPopoverHide, 
        
               clearActiveReportAction, 
        
           }));

What changes do you think we should make in order to solve the problem?

We should add contentRef inside useImperativeHandle

    useImperativeHandle(ref, () => ({
        showContextMenu,
        hideContextMenu,
        showDeleteModal,
        hideDeleteModal,
        isActiveReportAction,
        instanceID,
        runAndResetOnPopoverHide,
        clearActiveReportAction,
        contentRef
    }));

What alternative solutions did you explore? (Optional)

N/A

fedirjh · 2023-09-30T16:31:29Z

@hungvu193 Proposal makes sense, this is a regression from #27221.

melvin-bot · 2023-10-01T07:30:07Z

Job added to Upwork: https://www.upwork.com/jobs/~0103f61623015d853c

melvin-bot · 2023-10-01T07:30:12Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

melvin-bot · 2023-10-01T07:31:18Z

Upwork job price has been updated to $250

mountiny · 2023-10-01T07:33:01Z

cc @OlimpiaZurek @gedu @thiagobrez @s-alves10 @hayata-suenaga noting this is a second blocker from the PR, keep an eye out for such regressions, thanks!

melvin-bot · 2023-10-01T09:37:29Z

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-01T09:37:33Z

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-02T15:34:55Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-02T15:35:09Z

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-02T17:23:12Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-02T17:23:16Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP-Staging]:fix crash while opening emoji picker #28558

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment offer (Contributor)
@abdulrahuman5196 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-02T17:23:18Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-03T15:37:59Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP-Staging]:fix crash while opening emoji picker #28558

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment offer (Contributor)
@abdulrahuman5196 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-03T15:38:01Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

puneetlath · 2023-10-09T17:13:13Z

@abdulrahuman5196 friendly reminder on the checklist.

abdulrahuman5196 · 2023-10-09T17:47:41Z

The PR that introduced the bug has been identified. Link to the PR:

#27221

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/27221/files#r1350610872

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Its a minor bug and won't be benificial to add regression test.

cc: @puneetlath

puneetlath · 2023-10-11T21:47:37Z

All paid. Thanks everyone!

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 30, 2023

github-actions bot added Engineering Hourly KSv2 labels Sep 30, 2023

OSBotify mentioned this issue Sep 30, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

melvin-bot bot assigned johnmlee101 Sep 30, 2023

mountiny assigned mountiny and hungvu193 and unassigned johnmlee101 Oct 1, 2023

mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 1, 2023

melvin-bot bot changed the title ~~Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker~~ [$500] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker Oct 1, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 1, 2023

melvin-bot bot assigned thesahindia Oct 1, 2023

mountiny changed the title ~~[$500] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker~~ [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker Oct 1, 2023

mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 1, 2023

hungvu193 mentioned this issue Oct 1, 2023

[CP-Staging]:fix crash while opening emoji picker #28558

Merged

59 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 1, 2023

mountiny assigned abdulrahuman5196 and unassigned thesahindia Oct 1, 2023

mountiny unassigned puneetlath and hungvu193 Oct 2, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 2, 2023

mountiny assigned hungvu193 Oct 2, 2023

mountiny assigned puneetlath Oct 2, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Oct 2, 2023

melvin-bot bot changed the title ~~[$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker~~ [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker Oct 2, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 2, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 3, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 9, 2023

abdulrahuman5196 mentioned this issue Oct 9, 2023

migrate PopoverReportActionContextMenu class to function component #27221

Merged

59 tasks

puneetlath closed this as completed Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

kbecciv commented Sep 30, 2023 •

edited by melvin-bot bot

Loading

OSBotify commented Sep 30, 2023

melvin-bot bot commented Sep 30, 2023

hungvu193 commented Sep 30, 2023 •

edited

Loading

fedirjh commented Sep 30, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

mountiny commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

puneetlath commented Oct 9, 2023

abdulrahuman5196 commented Oct 9, 2023

puneetlath commented Oct 11, 2023

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

Comments

kbecciv commented Sep 30, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

OSBotify commented Sep 30, 2023

melvin-bot bot commented Sep 30, 2023

hungvu193 commented Sep 30, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

fedirjh commented Sep 30, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

mountiny commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 1, 2023

melvin-bot bot commented Oct 2, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

puneetlath commented Oct 9, 2023

abdulrahuman5196 commented Oct 9, 2023

puneetlath commented Oct 11, 2023

kbecciv commented Sep 30, 2023 •

edited by melvin-bot bot

Loading

hungvu193 commented Sep 30, 2023 •

edited

Loading