[HOLD for payment 2024-04-05] [$500] mWeb - Cursor jumps back to the start when adding an emoji in edit

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report on staging ND
2. Send a text message
3. Hold on the message and tap on edit the message
4. Click the emoji button in the text input
5. select an emoji

Expected Result:

The cursor should stay after the emoji when an emoji is added

Actual Result:

The cursor jumps to the start of the text when an emoji is added while editing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20231001_184036.mp4

Screen_Recording_20231001_124540_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696174769247349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01edb4567dee0b0a57
• Upwork Job ID: 1708949538648821760
• Last Price Increase: 2023-10-16

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

I cannot repro this in ios

[neil-marcellini]

I'll check if I can reproduce it on Android Chrome now.

[neil-marcellini]

I can't reproduce this on staging so we can close this.

Android-Emoji.mp4

[mountiny]

Thanks!

[jo-ui]

@neil-marcellini @mountiny It is still reproducible on android chrome but not on ios. Please check again with cleared cookies.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Reopening to confirm

[sakluger]

Since @jo-ui confirmed it is broken on android only, and Applause confirmed it's reproduceable on android, I'm going to add labels.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01edb4567dee0b0a57

[melvin-bot]

This issue has not been updated in over 15 days. @sakluger, @artus9033, @neil-marcellini, @abdulrahuman5196 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[neil-marcellini]

Closing the old PR, per this comment, and re-assigning this to @MrRefactor. Sorry for the delay, it got lost in all the noise! Thanks for the DMs to raise it back to my attention.

[neil-marcellini]

@MrRefactor would you please comment so myself or @sakluger can assign you?

[MrRefactor]

@MrRefactor would you please comment so myself or @sakluger can assign you?

Hey! I will open new pr soon

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix problem with cursor jumping back to start when adding an emoji in edit mode #37666

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @MrRefactor does not require payment (Contractor)
• @abdulrahuman5196 requires payment (Needs manual offer from BZ)
• @jo-ui requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Send a message to a chat
2. Long-press it and select "Edit comment" in the context menu
3. Append a new emoji from the emoji picker sliding menu - repeat this in several edge cases: in-between existing text, after text, before text
4. Ensure the cursor position is each time in the expected position and does not jump to the start of the text

[sakluger]

Summarizing payment on this issue:

Bug reporter: @jo-ui $50, sent offer via Upwork
Contributor: @MrRefactor, No payment required
Contributor+: @abdulrahuman5196 $500, sent offer via Upwork

[abdulrahuman5196]

@sakluger accepted the offer

[jo-ui]

@sakluger I accepted the offer

[sakluger]

Thanks everyone! I paid out all contracts and created a separate issue for the new regression test steps.