Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Workspace - No workspace available when signing in from a user with only one workspace #28564

Closed
6 tasks done
kbecciv opened this issue Oct 1, 2023 · 39 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Oct 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a very new account
  2. Create a workspace
  3. Signout and signin again
  4. Observe that workspace is not displayed.

1. Open App and login using the Apple ID (tap the Apple icon)
2. Click Continue for all the prompts
3. Navigate to Settings -> Workspaces (Make a few workspaces)
4. Sign out
5. Sign in with Apple ID and Navigate to Settings -> Workspaces (notice a workspace is deleted)

Note: WS is gone

6. Close the app (put app into background)
7. Open app again

Note: WS is visible.

Expected Result:

List of workspaces should appear if available

Actual Result:

List of workspaces does not appear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

unavilable_ws_desktop.1.mov
unavailable_ws_web.1.mov
unavailable_ws_ios.1.MP4
unavailable_ws_mweb.1.MP4
0-02-01-323b42a1bd67e836358abfd6bd671dd81ca89a2afacb9eb40e80d4f013a3a4e7_ef44ab50a7cc7d2e.mp4
Image.from.iOS.1.mp4

Image from iOS (1) (1)

Expensify/Expensify Issue URL:
Issue reported by: @ufumerfarooq
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696001301025309

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f132917068b6c5f3
  • Upwork Job ID: 1708527646262095872
  • Last Price Increase: 2023-10-12
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 1, 2023
@melvin-bot melvin-bot bot changed the title Workspace - No workspace available when login using Apple [$500] Workspace - No workspace available when login using Apple Oct 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f132917068b6c5f3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@Christinadobrzyn
Copy link
Contributor

i can reproduce - this might need to be Internal since it's related to Apple. What do you think @0xmiroslav (internal or external)?

@0xmiros
Copy link
Contributor

0xmiros commented Oct 2, 2023

I think this is BE issue so internal

@Christinadobrzyn Christinadobrzyn added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Oct 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Christinadobrzyn Christinadobrzyn removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 3, 2023
@MonilBhavsar
Copy link
Contributor

Hmm, I'm not able to reproduce this issue. I might be missing something here?

@ufumerfarooq
Copy link

@MonilBhavsar you need to use "Apple Signin" because it's still reproducible

@ufumerfarooq
Copy link

@MonilBhavsar Retested these 2 scenarios:
Scenario 1: Tested using old account
Note: Email was hidden by "Hide my email" apple feature and it's reproducible.

Scenario 2: Create a new account
Note: Hide my email was disabled for this account and the issue is still reproducible

My views: This issue is not with the "Hide my email" feature. It's something else
Videos are attached in Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696001301025309

@MonilBhavsar
Copy link
Contributor

Still no dice for me.
Had a look at the logs and nothing sus.
@Christinadobrzyn could you please retest and confirm

@Christinadobrzyn
Copy link
Contributor

I'm not able to reproduce anymore either. Following the steps in the OP - I signed in through Apple ID > created a workspace > signed out > signed back in and the workspace exists.

2023-10-04_09-10-09 (3)

This also seems to be the same behaviour as in this video in slack - https://expensify.slack.com/archives/C049HHMV9SM/p1696430345182549?thread_ts=1696001301.025309&cid=C049HHMV9SM

So if there's something else happening, I think that is a new bug report - this bug report doesn't seem to be happening anymore.

@MonilBhavsar
Copy link
Contributor

Thanks for confirming! @kbecciv is QA team able to reproduce this?
We need to update bug report if we're missing something or we can close this if we're not able to reproduce

@MonilBhavsar MonilBhavsar added the Needs Reproduction Reproducible steps needed label Oct 4, 2023
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Oct 4, 2023

I'll ask QA to test, good thinking!

Asked here - https://expensify.slack.com/archives/C9YU7BX5M/p1696434257640839

@kbecciv
Copy link
Author

kbecciv commented Oct 4, 2023

@Christinadobrzyn Workspace is unavailable after re-logging, but it reappears after close and reopen the app. Please check video. Thank you

RPReplay_Final1696434955.MP4

@Christinadobrzyn
Copy link
Contributor

Yes, this is still happening @MonilBhavsar. Seems to only be happening on IOS. I updated the steps in the OP to reproduce. can you try to reproduce again?

@MonilBhavsar MonilBhavsar added the External Added to denote the issue can be worked on by a contributor label Oct 6, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

@Christinadobrzyn
Copy link
Contributor

Thank you so much for all the testing @MonilBhavsar!

@melvin-bot
Copy link

melvin-bot bot commented Oct 8, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@MonilBhavsar
Copy link
Contributor

Disagree to above message from Melvin since External label was applied on Friday! cc @Christinadobrzyn
Waiting on proposals...

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 9, 2023
@MonilBhavsar
Copy link
Contributor

Melvin, I updated above 😕

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@Christinadobrzyn
Copy link
Contributor

waiting on proposals!

@Christinadobrzyn
Copy link
Contributor

increase the price to get some proposals

@Christinadobrzyn Christinadobrzyn changed the title [$500] Workspace - No workspace available when signing in from a user with only one workspace [$1000] Workspace - No workspace available when signing in from a user with only one workspace Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Upwork job price has been updated to $1000

@MonilBhavsar
Copy link
Contributor

I'll post in expert contributors group considering a critical issue and might be affecting other flows of the app

@paultsimura
Copy link
Contributor

paultsimura commented Oct 13, 2023

Seems like the RCA is the same as here: #28737

In the OpenApp API response, we have 2 Onyx operations related to the newly created policy:

{
            "onyxMethod": "mergecollection",
            "key": "policy_",
            "value": {
                "policy_7D84B7F95450B5C8": {
                    "isFromFullPolicy": false,
                    "id": "7D84B7F95450B5C8",
                    "name": "Paultsimura+ws5's Workspace",
                    "role": "admin",
                    "type": "free",
                    "owner": "paultsimura+ws5@gmail.com",
                    "outputCurrency": "PLN",
                    "avatar": "",
                    "employeeList": [],
                    "isPolicyExpenseChatEnabled": true,
                    "areChatRoomsEnabled": true,
                    "lastModified": 1697185648456091
                },
            }
        },
        {
            "onyxMethod": "merge",
            "key": "policy_7D84B7F95450B5C8",
            "value": {
                "autoReporting": true,
                "autoReportingFrequency": "immediate",
                "defaultBillable": false,
                "disabledFields": {
                    "defaultBillable": true,
                    "reimbursable": false
                }
            }
        },

After this response is processed, in Onyx the policy contains only the data from the merge operation, the mergecollection is neglected:

image

@Julesssss @ospfranco you might be interested ☝️

@MonilBhavsar
Copy link
Contributor

Looks like this is fixed now. I am not able to reproduce

@paultsimura
Copy link
Contributor

paultsimura commented Oct 13, 2023

@MonilBhavsar reproduced just now.

Prod:
image

Latest main:
image

@MonilBhavsar
Copy link
Contributor

I tried on staging. I'll try on main

@MonilBhavsar
Copy link
Contributor

I'm not able to reproduce on latest main either 🤔

@melvin-bot
Copy link

melvin-bot bot commented Oct 15, 2023

@MonilBhavsar @Christinadobrzyn @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 15, 2023
@MonilBhavsar
Copy link
Contributor

@Christinadobrzyn are you still able to reproduce this issue? I am not able to reproduce. I believe it's fixed. cc @0xmiroslav

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2023
@MonilBhavsar
Copy link
Contributor

Closing this issue. Feel free to reopen if issue still persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants