Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Request money - Unselecting split bill users displays the user as selected for sometime in recent list #28604

Closed
5 of 6 tasks
izarutskaya opened this issue Oct 2, 2023 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Oct 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Click on plus and click on request money->manual
  3. Enter any amount and click on next
  4. Select few users
  5. Unselect users one by one and observe that after unselect, it displays user as selected but in recent menu for sometime making UI appear glitchy

Expected Result:

App should display users only with split button in recent list

Actual Result:

On unselecting users, app displays users as selected in recent list for sometime making the UI look glitchy

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.75-8

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

ios.safari.clicking.on.selected.user.displays.user.selected.even.in.below.list.for.sometime.mov
mac.chrome.desktop.clicking.on.selected.user.displays.user.selected.even.in.below.list.for.sometime.mov
windows.chrome.clicking.on.selected.user.displays.user.selected.even.in.below.list.for.sometime.mp4
android.chrome.clicking.on.selected.user.displays.user.selected.even.in.below.list.for.sometime.mp4
ios.native.unselect.split.user.glitch.mov
native.native.unselect.split.user.glitch.mov
2023-10-02.13.10.10.mov

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696181711297889

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c0dc67a4334ea429
  • Upwork Job ID: 1708813370048184320
  • Last Price Increase: 2023-10-02
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 2, 2023
@melvin-bot melvin-bot bot changed the title Request money - Unselecting split bill users displays the user as selected for sometime in recent list [$500] Request money - Unselecting split bill users displays the user as selected for sometime in recent list Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c0dc67a4334ea429

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

@ZhenjaHorbach
Copy link
Contributor

This should already be fixed in this PR
#28274

@abekkala
Copy link
Contributor

abekkala commented Oct 2, 2023

@neil-marcellini can you confirm the PR linked would fix this as well?
#28274

@neil-marcellini
Copy link
Contributor

Yeah as I recall it does fix this issue. To be sure we can retest when #28274 hits staging 🙂

@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@abekkala
Copy link
Contributor

abekkala commented Oct 5, 2023

Confirmed that this is no longer happening. The fix on the the other PR has resolved this issue.

@abekkala abekkala closed this as completed Oct 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants