Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] Update permission button copy after feedback from Apple App Store team #28633

Closed
AndrewGable opened this issue Oct 2, 2023 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@AndrewGable
Copy link
Contributor

AndrewGable commented Oct 2, 2023

Problem

The iOS app is being rejected:

Guideline 5.1.1 - Legal - Privacy - Data Collection and Storage

We noticed your app encourages or directs users to allow the app to access the camera. Specifically, your app directs the user to grant permission in the following way(s):

  • A message appears before the permission request, and to proceed users press a “give “permission button. Use words like "Continue" or "Next" on the button instead.
    Permission requests give users control of their personal information. It is important to respect their decision about how their data is used.

Next Steps
To resolve this issue, please revise the permission request process in your app to not display messages before the permission request with inappropriate words on buttons.

If necessary, you may provide more information about why you are requesting permission before the request appears. If the user is trying to use a feature in your app that won't function without access to the camera, you may include a notification to inform the user and provide a link to the Settings app.

Solution

Update button copy to say Continue

Screenshot-0929-095600 (1)

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a47cef9baf05cc53
  • Upwork Job ID: 1708891024463171584
  • Last Price Increase: 2023-10-02
@AndrewGable AndrewGable added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 2, 2023
@AndrewGable AndrewGable self-assigned this Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a47cef9baf05cc53

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 2, 2023
@Julesssss
Copy link
Contributor

PR merged and CP'd/ But in the meantime I think the latest release passed review somehow 😆

Screenshot 2023-10-03 at 09 48 29

@AndrewGable
Copy link
Contributor Author

Well that's good news, we have fixed it for good now!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 3, 2023
@melvin-bot melvin-bot bot changed the title Update permission button copy after feedback from Apple App Store team [HOLD for payment 2023-10-10] Update permission button copy after feedback from Apple App Store team Oct 3, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 5, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-10] Update permission button copy after feedback from Apple App Store team [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] Update permission button copy after feedback from Apple App Store team Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants