[HOLD for payment 2023-10-25] [ECARD] CRITICAL: Transactions - Link eReceipt Page to Receipt Preview

[grgia]

Design Doc Section

https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.epr31aowxop2

Overview

Goal:
Once we have the new eReceipt page component, let’s link to it from the existing Transaction Thread.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e287df581057f74
• Upwork Job ID: 1709590903554031616
• Last Price Increase: 2023-10-04

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e287df581057f74

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[MitchExpensify]

This seems a little different from the typical New Feature flow in the BZ SO, how would you like me to handle this ideally @joekaufmanexpensify / @grgia ? 😎

[joekaufmanexpensify]

Yeah, I think it's fine if you un-assign. IDT this really needs anyone from BZ for now. Once C+ reviews the PR, I think we create a separate payment issue then. And if not, we can assign someone from BZ then to handle payment.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[Santhosh-Sellavel]

@rushatgabhane is the C+ here as he reviewed the PR. Please assign him here.

[melvin-bot]

@rushatgabhane, @grgia Eep! 4 days overdue now. Issues have feelings too...

[grgia]

@MitchExpensify or @joekaufmanexpensify could you verify that @rushatgabhane received $500 C+ review payment for #29474

[MitchExpensify]

@rushatgabhane payment issue created https://www.upwork.com/jobs/~01d5f78c44d5c389cc

[melvin-bot]

@rushatgabhane, @grgia Eep! 4 days overdue now. Issues have feelings too...

[grgia]

bump on payment status @rushatgabhane @MitchExpensify

[MitchExpensify]

Payment summary:

$500 - @rushatgabhane C+

Did you receive this yet on NewDot, @rushatgabhane ?

[rushatgabhane]

request here https://staging.new.expensify.com/r/5785180555158358

we can close the issue because payment will be tracked on new dot

[JmillsExpensify]

$500 payment approved for @rushatgabhane based on comment above.