[HOLD for payment 2023-10-25] [ECard Transactions] Update Report Preview Logic to support rendering JSX

[grgia]

Design Doc Section

https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=id.zalljxs7o0fd

Overview

Goal:
Add support for displaying ReceiptBackground component to the current logic for displaying receipts that is used in the ReportPreview, MoneyRequestAction/MoneyRequestPreview, and MoneyRequestView components. Currently we only support images, docX, and SVG from the Scan Receipt project. Most of this logic will be handled by updating ReportActionItemImages / ReportActionItemImage.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f38c76665e594519
• Upwork Job ID: 1709591008839544832
• Last Price Increase: 2023-10-04

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f38c76665e594519

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @burczu (Internal)

[melvin-bot]

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[joekaufmanexpensify]

@burczu please let us know if you can prioritize reviewing this one today, as this is related to a project with a deadline coming up EOW.

[puneetlath]

@joekaufmanexpensify going to re-assign BZ role to you since this is for wave8.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[joekaufmanexpensify]

@burczu mind proposing a new regression test for this? Once that's done, we can close this one (since no direct payment is required here)

[joekaufmanexpensify]

Bumped here.

[joekaufmanexpensify]

Switching assignees based on this thread, since Rushat reviewed this PR.

[joekaufmanexpensify]

Not overdue. @rushatgabhane is anything needed for the BZ checklist here?

[joekaufmanexpensify]

Bumped in Slack

[joekaufmanexpensify]

Still pending input

[rushatgabhane]

@joekaufmanexpensify we can add regression steps only after Expensify Card feature is completly implemented. Because the PR was tested using fake transaction data

[joekaufmanexpensify]

Okay got it. We will add regression tests for the entire issue holistically once it's implemented then. Closing as this is otherwise all set!