Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD - pending convo][ECARD] HIGH: Transactions - Update Admin Pay Button Copy in ReportPreview/MoneyReportHeader #28837

Closed
grgia opened this issue Oct 4, 2023 · 17 comments
Closed

[HOLD - pending convo][ECARD] HIGH: Transactions - Update Admin Pay Button Copy in ReportPreview/MoneyReportHeader #28837

grgia opened this issue Oct 4, 2023 · 17 comments
Assignees
@CortneyOfstad @s77rt @grgia
Labels
ECard Wave5-free-submitters Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Oct 4, 2023 •
edited
Loading

Design Doc Section

HOLD - see https://expensify.slack.com/archives/C05DWUDHVK7/p1700678791026919?thread_ts=1700600632.494789&cid=C05DWUDHVK7 and https://expensify.slack.com/archives/C036QM0SLJK/p1700232942102839

https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.gq501xywgfmv

Overview

Goal:
Update the Pay Button depending on admin view, policy type, and types of transactions on the report.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019cd4005e678faab2
  • Upwork Job ID: 1709592172256550912
  • Last Price Increase: 2023-10-04
@grgia grgia self-assigned this Oct 4, 2023
@grgia grgia added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~019cd4005e678faab2

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 13, 2023
@CortneyOfstad
Copy link
Contributor

Not overdue 👍

@joekaufmanexpensify
Copy link
Contributor

@grgia going through the wave 8 project, and saw this issue. Is this a critical part of the implementation, or more of a clean up issue?

@grgia
Copy link
Contributor Author

grgia commented Oct 23, 2023

@joekaufmanexpensify not critical, but I can get this done by tomorrow

@joekaufmanexpensify
Copy link
Contributor

Cool cool, ty! Just wanted to confirm whether to put it in the update. But I'll leave it out for now if not critical.

@Gonals Gonals mentioned this issue Oct 24, 2023
Closed
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2023
@CortneyOfstad
Copy link
Contributor

Any action needed from me @grgia? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 31, 2023

@CortneyOfstad not currently, just for C+ payment tracking when we do work on this PR

@dylanexpensify dylanexpensify changed the title [ECard Transactions] Update Admin Pay Button Copy in ReportPreview/MoneyReportHeader [ECARD] HIGH: Transactions - Update Admin Pay Button Copy in ReportPreview/MoneyReportHeader Nov 7, 2023
@dylanexpensify dylanexpensify added the ECard Wave5-free-submitters label Nov 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 9, 2023
@grgia
Copy link
Contributor Author

grgia commented Nov 9, 2023

Will work on this tomorrow (Fri)

@melvin-bot melvin-bot bot removed the Overdue label Nov 9, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@grgia
Copy link
Contributor Author

grgia commented Nov 20, 2023

Holding on the auth command

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2023
@grgia grgia changed the title [ECARD] HIGH: Transactions - Update Admin Pay Button Copy in ReportPreview/MoneyReportHeader [HOLD - pending convo][ECARD] HIGH: Transactions - Update Admin Pay Button Copy in ReportPreview/MoneyReportHeader Nov 22, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2023
@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2023
@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Dec 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Dec 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 28, 2023
@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2024
@CortneyOfstad
Copy link
Contributor

@grgia any action needed? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Jan 10, 2024
@grgia grgia closed this as completed Jan 10, 2024
@idanbe4 idanbe4 mentioned this issue May 17, 2024
Open
@MelvinBot MelvinBot mentioned this issue May 17, 2024
Closed
50 tasks
@melvin-bot melvin-bot bot mentioned this issue May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CortneyOfstad CortneyOfstad

@s77rt s77rt

@grgia grgia

Labels
ECard Wave5-free-submitters Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
[#whatsnext] Wave 05 - Deprecate Free
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@CortneyOfstad @s77rt @grgia @joekaufmanexpensify @dylanexpensify