[$500] Hmm.. it's not here page is displayed when opening a 'share code' link for public account only

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: user A and user B should have no prior chat history (only public accounts)

1. Open a tab where user A is signed in
2. Click on 'Profile avatar' > Share code > Copy URL to clipboard
3. Open a tab where user B is signed in
4. Paste the URL to the address bar
5. Press enter

Expected Result:

User A's profile should be opened

Actual Result:

Hmm.. it's not here page is displayed when opening a 'share code' link for public account only

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.79.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-09.at.2.57.51.PM.mov

Screen_Recording_20231009_093504_Chrome.mp4

Screen.Recording.2023-10-09.at.9.08.24.AM.1.mov

Recording.4907.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696831942996729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e8af5839a345db28
• Upwork Job ID: 1711873748178976768
• Last Price Increase: 2023-10-10

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

Clarified here that the expected behavior is that "Hidden" should show:

[jasperhuangg]

Going to revert #28812 which caused this regression

[Natnael-Guchima]

@jasperhuangg I wasn't paid for reporting bonus. Can you please open this issue to handle reporting bonus?

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e8af5839a345db28

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[mountiny]

Reopening to pay $50 to @Natnael-Guchima for reporting cc @mallenexpensify

[mallenexpensify]

@Natnael-Guchima can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01e8af5839a345db28

Sorry we missed it

[Natnael-Guchima]

@mallenexpensify I haven't received an offer. Can you please send me an offer? Thanks.

And no worries 🙏

A link to my profile, if need: https://www.upwork.com/freelancers/nathnaelg?s=1313512633755545600

[ginsuma]

The app crashes when opening an unknown profile URL now. It should show a hidden profile page.

Screen.Recording.2023-10-11.at.4.09.27.PM.mov

The reason is the below LOC.

App/src/pages/ProfilePage.js

Lines 307 to 317 in d1ff84b

	withOnyx({
	report: {
	key: ({route, session}) => {
	const accountID = Number(lodashGet(route.params, 'accountID', 0));
	if (Number(session.accountID) === accountID || Session.isAnonymousUser()) {
	return null;
	}
	return `${ONYXKEYS.COLLECTION.REPORT}${lodashGet(ReportUtils.getChatByParticipants([accountID]), 'reportID', '')}`;
	},
	},
	}),

props.report will return all reports because ReportUtils.getChatByParticipants([accountID]) is undefined.
We should update the condition to:

if (Number(session.accountID) === accountID || Session.isAnonymousUser() || !ReportUtils.getChatByParticipants([accountID])) {
    return null;
}

cc: @jasperhuangg @mountiny

[mallenexpensify]

@Natnael-Guchima can you please accept the updated job and reply here once you have?
https://www.upwork.com/jobs/~01e8af5839a345db28

[Natnael-Guchima]

I have accepted the offer. Thanks @mallenexpensify

[mallenexpensify]

Issue reporter: @Natnael-Guchima paid $50 via Upwork

@jasperhuangg, should we look into @ginsuma 's comment above about the app crashing with unknown profile URL? Should that be a separate bug report? Thx

[jasperhuangg]

I think we can fix that in the same bug report. @ginsuma do you want to get a PR up for that?

[ginsuma]

@jasperhuangg, we already created an issue for it. #29313.

[jasperhuangg]

Are we all sorted here to close this out? @mallenexpensify

[mallenexpensify]

I think so @jasperhuangg