[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link #29183

kbecciv · 2023-10-10T13:21:01Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.80.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696863974272199

Action Performed:

Create a request money
Click request preview
Click request item
Click date and copy url
Create a public room and send URL
Logout and open the publish room
Click open url

Expected Result:

App does not crash

Actual Result:

App crash when open edit date request money by deep link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2023-10-09.at.22.36.55.1.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-10-09.at.22.49.25.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-09.at.22.06.44.mov

MacOS: Desktop

Screen.Recording.2023-10-09.at.22.26.22.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c4f5d983bc3511a7
Upwork Job ID: 1711819993131061248
Last Price Increase: 2023-10-10

OSBotify · 2023-10-10T13:22:34Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-10T13:22:37Z

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

namhihi237 · 2023-10-10T13:22:44Z

This issue come from #28645

puneetlath · 2023-10-10T14:05:01Z

@tgolen mind taking a look? Seems to be coming from your PR.

saranshbalyan-1234 · 2023-10-10T16:39:32Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash when open edit date request money by deep link

What is the root cause of that problem?

While page is being accessed via deep link, initially report object is null which gives this error as we cannot access properties of null or undefined here

App/src/pages/EditRequestPage.js

Lines 323 to 326 in b2cbd26

    
           key: ({report, parentReportActions}) => { 
        
               const parentReportAction = lodashGet(parentReportActions, [report.parentReportActionID]); 
        
               return `${ONYXKEYS.COLLECTION.TRANSACTION}${lodashGet(parentReportAction, 'originalMessage.IOUTransactionID', 0)}`; 
        
           },

What changes do you think we should make in order to solve the problem?

use report object like we use in other places of same component like this

App/src/pages/EditRequestPage.js

Line 316 in b2cbd26

    
           key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '0'}`,

thus the solution would look something like this

 const parentReportAction = lodashGet(parentReportActions, [report ? report.parentReportActionID : '0']);

What alternative solutions did you explore? (Optional)

N/A

tgolen · 2023-10-10T19:03:47Z

@saranshbalyan-1234 Has the correct solution 👍

melvin-bot · 2023-10-10T19:04:27Z

Job added to Upwork: https://www.upwork.com/jobs/~01c4f5d983bc3511a7

melvin-bot · 2023-10-10T19:04:34Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

puneetlath · 2023-10-10T19:12:08Z

@saranshbalyan-1234 can you raise a PR asap?

saranshbalyan-1234 · 2023-10-10T19:12:58Z

@puneetlath sure, on it

saranshbalyan-1234 · 2023-10-10T20:05:22Z

PR is raised, please check
Handled some more conditions to get all the edge case scenario as well

jasperhuangg · 2023-10-11T02:58:59Z

Removing the deploy blocker label since this is reproducible on production too

tgolen · 2023-10-11T14:13:25Z

The PR has been merged and I am cherry-picking it to staging right now. @kbecciv Can you please revalidate this on staging once it is deployed?

kbecciv · 2023-10-11T18:37:49Z

Checking, will update you shortly

kbecciv · 2023-10-11T18:40:45Z

@tgolen Issue is reproducible on build 1.3.81.5

Recording.4957.mp4

melvin-bot · 2023-10-13T22:03:23Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-13T22:03:26Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix crash on deep link request page #29227

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment
@saranshbalyan-1234 requires payment
@namhihi237 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:55:17Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix crash on deep link request page #29227

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment
@saranshbalyan-1234 requires payment
@namhihi237 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:17:52Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix crash on deep link request page #29227

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment
@saranshbalyan-1234 requires payment
@namhihi237 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:43:34Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix crash on deep link request page #29227

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment
@saranshbalyan-1234 requires payment
@namhihi237 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-23T12:29:16Z

@puneetlath, @s77rt, @saranshbalyan-1234 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2023-10-25T12:54:01Z

@puneetlath, @s77rt, @saranshbalyan-1234 Eep! 4 days overdue now. Issues have feelings too...

puneetlath · 2023-10-25T13:23:45Z

Not sure why offers weren't auto-sent.

@saranshbalyan-1234 @namhihi237 can you please apply to the job? https://www.upwork.com/jobs/~01c4f5d983bc3511a7

namhihi237 · 2023-10-25T13:27:48Z

@puneetlath I submitted.

saranshbalyan-1234 · 2023-10-25T13:38:52Z

unable to apply, can you please send an offer

puneetlath · 2023-10-26T15:44:53Z

ok @saranshbalyan-1234 @namhihi237 you both have been sent offers. Please let me know when you've accepted.

namhihi237 · 2023-10-26T15:45:33Z

I accepted @puneetlath

saranshbalyan-1234 · 2023-10-26T15:46:45Z

Thank you @puneetlath accepted

puneetlath · 2023-10-26T15:48:25Z

Great, all paid. Thanks everyone!

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 10, 2023

github-actions bot added the Engineering label Oct 10, 2023

OSBotify mentioned this issue Oct 10, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

github-actions bot added the Hourly KSv2 label Oct 10, 2023

melvin-bot bot assigned puneetlath Oct 10, 2023

tgolen assigned saranshbalyan-1234 Oct 10, 2023

tgolen added the External Added to denote the issue can be worked on by a contributor label Oct 10, 2023

melvin-bot bot changed the title ~~Chat - App crash when open edit date request money by deep link~~ [$500] Chat - App crash when open edit date request money by deep link Oct 10, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 10, 2023

melvin-bot bot assigned s77rt Oct 10, 2023

saranshbalyan-1234 mentioned this issue Oct 10, 2023

Fix crash on deep link request page #29227

Merged

58 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 10, 2023

jasperhuangg removed the DeployBlockerCash This issue or pull request should block deployment label Oct 11, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link~~ [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link Oct 13, 2023

honnamkuan mentioned this issue Oct 15, 2023

[$500] Split bill - When delete Split Bill report from attendee DM & go back - Error page showing #29497

Closed

6 tasks

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 20, 2023

melvin-bot bot removed the Overdue label Oct 25, 2023

puneetlath closed this as completed Oct 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link #29183

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link #29183

kbecciv commented Oct 10, 2023 •

edited by melvin-bot bot

Loading

OSBotify commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

namhihi237 commented Oct 10, 2023

puneetlath commented Oct 10, 2023

saranshbalyan-1234 commented Oct 10, 2023

tgolen commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

puneetlath commented Oct 10, 2023

saranshbalyan-1234 commented Oct 10, 2023

saranshbalyan-1234 commented Oct 10, 2023 •

edited

Loading

jasperhuangg commented Oct 11, 2023

tgolen commented Oct 11, 2023

kbecciv commented Oct 11, 2023

kbecciv commented Oct 11, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 •

edited by puneetlath

Loading

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 25, 2023

puneetlath commented Oct 25, 2023

namhihi237 commented Oct 25, 2023

saranshbalyan-1234 commented Oct 25, 2023

puneetlath commented Oct 26, 2023

namhihi237 commented Oct 26, 2023

saranshbalyan-1234 commented Oct 26, 2023

puneetlath commented Oct 26, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link #29183

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link #29183

Comments

kbecciv commented Oct 10, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

OSBotify commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

namhihi237 commented Oct 10, 2023

puneetlath commented Oct 10, 2023

saranshbalyan-1234 commented Oct 10, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tgolen commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

puneetlath commented Oct 10, 2023

saranshbalyan-1234 commented Oct 10, 2023

saranshbalyan-1234 commented Oct 10, 2023 • edited Loading

jasperhuangg commented Oct 11, 2023

tgolen commented Oct 11, 2023

kbecciv commented Oct 11, 2023

kbecciv commented Oct 11, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 • edited by puneetlath Loading

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 25, 2023

puneetlath commented Oct 25, 2023

namhihi237 commented Oct 25, 2023

saranshbalyan-1234 commented Oct 25, 2023

puneetlath commented Oct 26, 2023

namhihi237 commented Oct 26, 2023

saranshbalyan-1234 commented Oct 26, 2023

puneetlath commented Oct 26, 2023

kbecciv commented Oct 10, 2023 •

edited by melvin-bot bot

Loading

saranshbalyan-1234 commented Oct 10, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by puneetlath

Loading