[$500] Chat - Input field briefly disappears after saving edited message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.80-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Open the app
2. Navigate to any chat
3. Send a message
4. Long tap the message you just sent
5. Select "Edit"
6. With or without editing tap "Save"

Expected Result:

The chat Input field should remain visible

Actual Result:

The chat Input field briefly disappears after tapping "Save"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6231989_1696949869394.IMG_2360.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016c8e10c73a6f0920
• Upwork Job ID: 1712585872937078784
• Last Price Increase: 2023-10-26

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

I can't reproduce this - the saved "Edit" flickers but it doesn't disappear. I think we need a video and the steps checked in the OP.

asking QA - https://expensify.slack.com/archives/C9YU7BX5M/p1697140719305749

[izarutskaya]

Hi @Christinadobrzyn, I can reproduce this issue with build v1.3.83-4 on iOS 16.6.1. Input field disappears for a moment for me. It's like scrolling down off the screen.

Rpreplay.Final1697142926.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016c8e10c73a6f0920

[Christinadobrzyn]

I can reproduce - I think this can be external.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

@Christinadobrzyn, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[barttom]

Hey!! I'm Bartek from Callstack and I would like to help with this issue. I will send the proposal soon

[Christinadobrzyn]

Awesome! Thanks @barttom - feel free to add the proposal here for a review!

[barttom]

Hey!
Small update from my side.
I'm still investigating this issue.

What I found is not like input disappearing, but it shows with delay. This feature is implemented like:

• when the user want to edit a comment - display the input field instead of the comment content
• hide new message input on the footer
• After finishing editing: show input on the footer again

So there are two inputs and there could be more if we decide to edit a few messages at the same time.
The problem is first render of ReportActionCompose in the footer. Looks like it has expensive operations before rendering.
Maybe this PR resolves this issue, I'll check that.
So I'm still working on the proposal :)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Christinadobrzyn]

hi @thesahindia can you provide an update on the proposal review? Thanks!

[thesahindia]

@Christinadobrzyn, @barttom is still working on the proposal.

[barttom]

@Christinadobrzyn yup, still looking for solution.

This issue is tricky. I find out that delay with render bottom input happens only when we have opened keyboard. I’m analysing keyboard listeners and looking for reason of this behaviour.

[tgolen]

The proposal looks OK to me too. @barttom Did you look into the git blame of that method to see if there was a specific reason that it was using keyboardDidHide in the first place?

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Reviewer role ($500)

[barttom]

Hi @s-alves10!
I have one question about the solution from #23908 (comment)

Was there a specific reason to choose 'keyboardDidHide' listener event?
That provides a delay in displaying input after ending the editing comment, so just wonder if this was a requirement.

[barttom]

@tgolen FYI - this is an origin issue #2390, asked the question above :)

[s-alves10]

@barttom

That was added in #15201 to fix the issue #15086.

[barttom]

It's super weird but when I tested if we don't have a regression with the flashing mentioned here, I realized that on Android main input didn't show. So I've changed my pull request to listen event conditionally based on the platform
No flashing observed

Screen.Recording.2023-10-31.at.14.41.58.mov

[tgolen]

Great, thanks for checking on that and it sounds like it was a good thing that we looked into it!

[Christinadobrzyn]

I'm going ooo until Monday Nov 27th so going to assign another BZ teammate to monitor this until I'm back. Thanks!

Status: discussing the solution

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[barttom]

The fiox was merged in production two weeks ago, should we close this issue?

[Christinadobrzyn]

Ah good catch @barttom! This is the PR for this right? #30564

Not sure why the payment prompt didn't show. I don't see anything about regressions so I think we can pay this out.

Do we need a regression for this @barttom @thesahindia?

[barttom]

I don't think we need a regression test for this one

[Christinadobrzyn]

okay thanks! here's the payment structure

Payouts due:

Issue Reporter: NA
Contributor: $500 @barttom (Callstack so not paid through NewExpensify or Upwork)
Contributor+: $500 @thesahindia (through NewExpensify)

Eligible for 50% #urgency bonus? N

Upwork job is here.

Closing this out since payment happens outside Upwork. Let me know if I'm missing anything!

[JmillsExpensify]

$500 payment approved for @thesahindia based on comment above.