Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Money - 'Manual', 'Scan', and 'Distance' is not grayed out when they are not selected #29624

Closed
4 of 6 tasks
kbecciv opened this issue Oct 14, 2023 · 8 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Oct 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697234831059319

Action Performed:

  1. Click on FAB
  2. Request Money

Expected Result:

'Manual', 'Scan', and 'Distance' is grayed out when they are not selected

Actual Result:

'Manual', 'Scan', and 'Distance' is not grayed out when they are not selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
cannot verify - crash
Android: mWeb Chrome

sc

iOS: Native
cannot verify - app freezes
iOS: mWeb Safari

IMG_8172

MacOS: Chrome / Safari ![image (8)](https://github.com/Expensify/App/assets/93399543/6223ecfa-9416-48ab-83df-44c8d15754a9) ![image (7)](https://github.com/Expensify/App/assets/93399543/8f0f308e-f759-4c0c-bd95-e27a15babdcf)
MacOS: Desktop
2023-10-14.2.33.20.PM.mov

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 14, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@shubham1206agra
Copy link
Contributor

This will be fixed by #29629 ig

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

Also fixed by that PR, we only need to pay $50 for @daveSeife for reporting

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2023
@sakluger
Copy link
Contributor

@mountiny just to confirm, #29629 will fix this issue? If so, it looks like the bug report for #29611 was made before the bug report for this one, so I would think we would just close this as a duplicate and pay that reporting bonus.

Do you think we should pay this reporting bonus as well even if it's the same root cause?

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2023
@mountiny
Copy link
Contributor

I agree we can close this even this was very similar reports and same rootcause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants