Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - When we change category of manual request, a small shake can be seen #29877

Closed
4 of 6 tasks
lanitochka17 opened this issue Oct 18, 2023 · 27 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.86-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap a Workspace chat
  3. Tap plus icon near compose
  4. Tap request money---Manual
  5. Enter an amount
  6. Tap next
  7. Tap show more
  8. Select a category
  9. Tap Request
  10. Tap on IOU created
  11. Tap on IOU again to open IOU details page
  12. Tap category and select some other category other than selected

Expected Result:

When we change category of manual request, a small shake must not be seen

Actual Result:

When we change category of manual request, a small shake can be seen

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
Bug6241848_1697641007790.category_shaken.1.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
20231018_212302.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0164196a630a5ccb5f
  • Upwork Job ID: 1714699123316404224
  • Last Price Increase: 2023-11-08
Issue OwnerCurrent Issue Owner: @muttmuure
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@neil-marcellini
Copy link
Contributor

I'm taking a look now

@neil-marcellini
Copy link
Contributor

I confirmed that it's not reproducible on production, but is on staging. However, it's a very minor bug so IMO we shouldn't block deploy on it. I'll check to see if the deployer agrees.

production

production.mov

staging

staging.mov

@neil-marcellini
Copy link
Contributor

@francoisl is the deployer and agrees here (internally) that we can polish this later. I'm removing the blocker and making it external.

@neil-marcellini neil-marcellini added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 18, 2023
@melvin-bot melvin-bot bot changed the title IOU - When we change category of manual request, a small shake can be seen [$500] IOU - When we change category of manual request, a small shake can be seen Oct 18, 2023
@neil-marcellini neil-marcellini added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0164196a630a5ccb5f

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@neil-marcellini
Copy link
Contributor

Not overdue, waiting for proposals.

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2023
@brunovjk
Copy link
Contributor

I can not reproduce

@neil-marcellini
Copy link
Contributor

@muttmuure can you double check that and close if needed ^

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2023

@cubuspl42, @neil-marcellini, @muttmuure Eep! 4 days overdue now. Issues have feelings too...

@neil-marcellini
Copy link
Contributor

Bump @muttmuure

Copy link

melvin-bot bot commented Nov 1, 2023

@cubuspl42 @neil-marcellini @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Nov 1, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@neil-marcellini
Copy link
Contributor

Remove overdue, I bumped Matt

@muttmuure
Copy link
Contributor

Having trouble getting into expensifail.com to test this because 2FA is required

@melvin-bot melvin-bot bot removed the Overdue label Nov 2, 2023
@muttmuure
Copy link
Contributor

Still reproducible on staging

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

@cubuspl42, @neil-marcellini, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Nov 8, 2023

@cubuspl42 @neil-marcellini @muttmuure this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link

melvin-bot bot commented Nov 8, 2023

@cubuspl42, @neil-marcellini, @muttmuure Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Nov 8, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@erquhart
Copy link
Contributor

erquhart commented Nov 8, 2023

A duplicate was opened and has an accepted proposal: #30218

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

@cubuspl42, @neil-marcellini, @muttmuure Eep! 4 days overdue now. Issues have feelings too...

@muttmuure
Copy link
Contributor

Closing in favor of the other one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants