Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [Form Provider Refactor] WorkspaceSettingsPage #30006

Closed
luacmartins opened this issue Oct 19, 2023 · 14 comments
Closed

[$500] [Form Provider Refactor] WorkspaceSettingsPage #30006

luacmartins opened this issue Oct 19, 2023 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Oct 19, 2023

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/workspace/WorkspaceSettingsPage.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012338fed619c082d3
  • Upwork Job ID: 1715043402126536704
  • Last Price Increase: 2023-10-20
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@luacmartins luacmartins self-assigned this Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~012338fed619c082d3

@melvin-bot

This comment was marked as off-topic.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@luacmartins
Copy link
Contributor Author

SWM will work on this, no need for a proposal

@sakluger
Copy link
Contributor

@luacmartins do you still want @0xmiroslav to review this PR, or will you be reviewing yourself?

@luacmartins
Copy link
Contributor Author

@kowczarz will you take this one too?

@kowczarz
Copy link
Contributor

Yep, I will work on it on Monday

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 20, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] WorkspaceSettingsPage [$500] [Form Provider Refactor] WorkspaceSettingsPage Oct 20, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@luacmartins
Copy link
Contributor Author

@kowczarz is working on other forms at the moment. We'll get to this one soon!

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 25, 2023
@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Oct 26, 2023
@sakluger
Copy link
Contributor

PR is in review.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 24, 2023
Copy link

melvin-bot bot commented Nov 24, 2023

This issue has not been updated in over 15 days. @sakluger, @luacmartins, @kowczarz, @0xmiroslav eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kowczarz
Copy link
Contributor

The PR was deployed 6.11.2023 I think we can close the issue.

@mallenexpensify
Copy link
Contributor

Contributor+: @0xmiroslav owed $500 via Upwork

@mallenexpensify mallenexpensify removed the Reviewing Has a PR in review label Jan 24, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants