Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$125] [Form Provider Refactor] WaypointEditor #30008

Closed
luacmartins opened this issue Oct 19, 2023 · 25 comments
Closed

[$125] [Form Provider Refactor] WaypointEditor #30008

luacmartins opened this issue Oct 19, 2023 · 25 comments
Assignees
@hoangzinh @luacmartins @laurenreidexpensify @kowczarz
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Oct 19, 2023 •
edited by laurenreidexpensify
Loading

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/iou/WaypointEditor.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0165bf01aa20db61bc
  • Upwork Job ID: 1715043820395114496
  • Last Price Increase: 2023-11-28
Issue OwnerCurrent Issue Owner: @laurenreidexpensify
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@luacmartins luacmartins self-assigned this Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0165bf01aa20db61bc

@melvin-bot

This comment was marked as off-topic.

Sign in to view
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @hoangzinh (Internal)

@luacmartins
Copy link
Contributor Author

SWM will work on this, no need for a proposal

@kowczarz
Copy link
Contributor

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

@kowczarz
Copy link
Contributor

This one is blocked by #29983 as well

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 20, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] WaypointEditor [$500] [Form Provider Refactor] WaypointEditor Oct 20, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@laurenreidexpensify laurenreidexpensify changed the title [$500] [Form Provider Refactor] WaypointEditor [Hold on ##29983] [$500] [Form Provider Refactor] WaypointEditor Oct 23, 2023
@laurenreidexpensify
Copy link
Contributor

Making a weekly if there is a hold on ##29983

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Oct 23, 2023
@laurenreidexpensify
Copy link
Contributor

#29983 is on staging

@laurenreidexpensify
Copy link
Contributor

Looks like #29983 is on prod since Monday, so taking this off hold and making a daily again

@laurenreidexpensify laurenreidexpensify changed the title [Hold on ##29983] [$500] [Form Provider Refactor] WaypointEditor [$500] [Form Provider Refactor] WaypointEditor Nov 8, 2023
@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Nov 8, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2023
@kowczarz
Copy link
Contributor

I will work on it this week.

@luacmartins luacmartins changed the title [Hold on #31133] [$500] [Form Provider Refactor] WaypointEditor [Hold on #31133] [$125] [Form Provider Refactor] WaypointEditor Nov 28, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 28, 2023

Upwork job price has been updated to $125

@kowczarz kowczarz mentioned this issue Dec 1, 2023
Merged
47 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 1, 2023
@laurenreidexpensify laurenreidexpensify changed the title [Hold on #31133] [$125] [Form Provider Refactor] WaypointEditor [$125] [Form Provider Refactor] WaypointEditor Dec 5, 2023
@laurenreidexpensify
Copy link
Contributor

#31133 is deployed to prod, so moving off hold

@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Dec 5, 2023
@luacmartins
Copy link
Contributor Author

PR for this issue was merged yesterday and is in staging now.

@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Dec 5, 2023
@laurenreidexpensify
Copy link
Contributor

and back to weekly!

@hoangzinh
Copy link
Contributor

the PR has been deployed to PROD since 7/12 #32358 (comment). Melvin didn't auto-update the payment status of this issue here.

@laurenreidexpensify Can you process payment here? Thanks

@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Dec 20, 2023
@laurenreidexpensify laurenreidexpensify mentioned this issue Dec 20, 2023
Closed
@laurenreidexpensify
Copy link
Contributor

Payment Summary:

Contributor: $125 @hoangzinh offer sent in Upwork
C+: @kowczarz Expert Contributor N/A

@hoangzinh
Copy link
Contributor

Accepted. Thanks @laurenreidexpensify

@laurenreidexpensify
Copy link
Contributor

Payment Summary:

Contributor: $125 @hoangzinh paid in Upwork
C+: @kowczarz Expert Contributor N/A

@blazejkustra blazejkustra mentioned this issue Jan 18, 2024
Merged
49 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 18, 2024
@blazejkustra blazejkustra mentioned this issue Feb 7, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangzinh hoangzinh

@luacmartins luacmartins

@laurenreidexpensify laurenreidexpensify

@kowczarz kowczarz

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hoangzinh @luacmartins @laurenreidexpensify @kowczarz