[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] IOU - Tapping delete request, user is directed to "hmm...it's not here" page.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.87-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Launch app
2. Tap on a 1:1 report
3. Tap plus icon near compose box
4. Tap request money
5. Enter an amount
6. Tap next
7. Tap request amount
8. Tap on IOU transaction
9. Tap on IOU to open IOU detail page
10. Tap on 3dots and tap delete request and confirm delete

Expected Result:

When user tap delete request, IOU must be deleted and user must not be shown hhm it's not here page

Actual Result:

When user tap delete request, he is directed to "hmm...it's not here" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6243476_1697743292536.request.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

@lanitochka17 Can you share the URL that Hmm... it's not here is presenting on iOS: mWeb Safari?

[johnmlee101]

Okay have my own example
https://staging.new.expensify.com/r/64913349

the route seems fine since that was the base chat that originated my IOU, so it doesn't seem related to the route in the URL at least

[johnmlee101]

Oh interesting but refreshing takes me to https://staging.new.expensify.com/r/18863252980177 so let me see what that is. I bet its the IOU report that contains the IOU itself, so we're not properly back-pacing

[francoisl]

Discussion in the open source Slack channel here, we're closing in on a solution.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent useEffect from happening incorrectly for deleted IOU reports #30097

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl / @johnmlee101 / @jasperhuangg] The PR that introduced the bug has been identified. Link to the PR:
• [@francoisl / @johnmlee101 / @jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl / @johnmlee101 / @jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@francoisl / @johnmlee101 / @jasperhuangg] Determine if we should create a regression test for this bug.
• [@francoisl / @johnmlee101 / @jasperhuangg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent useEffect from happening incorrectly for deleted IOU reports #30097

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl / @johnmlee101 / @jasperhuangg] The PR that introduced the bug has been identified. Link to the PR: UI for room invitations/removals #27966
• [@francoisl / @johnmlee101 / @jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@francoisl / @johnmlee101 / @jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@francoisl / @johnmlee101 / @jasperhuangg] Determine if we should create a regression test for this bug. No
• [@francoisl / @johnmlee101 / @jasperhuangg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

@francoisl @jasperhuangg - what was the regression that caused this?

[francoisl]

I linked the PR in the checklist above, it was an internal PR. The issue was found by Applause and the fix was handled internally, so I don't think we need payments here?

[sophiepintoraetz]

No, no payments! A regression test though - so I'll loop in the author @jasperhuangg @fedirjh @Li357 - bumping here as well, please can you write up a regression test for this regression that came out of y'alls PR?
#27966 (comment)

[fedirjh]

@sophiepintoraetz, The C+ on the linked PR was @s77rt. They can assist with the regression test.

[s77rt]

Regression Test Proposal

1. Open a chat report with someone you have not chatted with before
2. Request money (using the plus + button in the composer)
3. Click on the IOU preview then on the transaction report action
4. Click on the 3 dots > Delete request
5. Verify you are redirected to the chat report

[sophiepintoraetz]

Thanks @s77rt!