Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace is not selected as participant when a manual request is created #30032

Closed
6 tasks done
marcochavezf opened this issue Oct 19, 2023 · 12 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Not a priority Reviewing Has a PR in review

Comments

@marcochavezf
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Coming from here

Action Performed:

  1. In a workspace chat, click on "Request money"
  2. Select manua, enter any amount
  3. Click on "Next" button

Expected Result:

The confirmation page should show the workspace in the field "to"

Actual Result:

Nothing is shown as a selected participant, and the "Request" button is disabled

Screen.Recording.2023-10-19.at.4.04.16.p.m.mov

Workaround:

No workaround

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

@marcochavezf marcochavezf added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@marcochavezf marcochavezf self-assigned this Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@thienlnam thienlnam added the DeployBlockerCash This issue or pull request should block deployment label Oct 19, 2023
@thienlnam
Copy link
Contributor

thienlnam commented Oct 19, 2023

In the thread, we found that it was likely caused by #27547

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Current assignee @marcochavezf is eligible for the Engineering assigner, not assigning anyone new.

@marcochavezf
Copy link
Contributor Author

marcochavezf commented Oct 20, 2023

PR that introduced the regression was reverted here. @Christinadobrzyn could you handle the payment for @hoangzinh? Since help us to test another PR and caught the original fix wasn't enough to fix the regression.

@marcochavezf marcochavezf removed the DeployBlockerCash This issue or pull request should block deployment label Oct 20, 2023
@Christinadobrzyn
Copy link
Contributor

Yep! @marcochavezf and @hoangzinh does $500 or $250 sound good for payment? Not sure how much work was done on this. Thanks!

@hoangzinh
Copy link
Contributor

I'm happy with $125 because it doesn't have much effort

@lukemorawski
Copy link
Contributor

@thienlnam @marcochavezf I think I have the solution to this problem so #27547 could be merged again.

@thienlnam
Copy link
Contributor

@lukemorawski Could you create another PR with the fix and then the original reviewers can take another look at it?

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 13, 2023
Copy link

melvin-bot bot commented Nov 13, 2023

This issue has not been updated in over 15 days. @marcochavezf, @hoangzinh, @Christinadobrzyn eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link

melvin-bot bot commented Jan 9, 2024

@marcochavezf, @hoangzinh, @Christinadobrzyn, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants