[HOLD for payment 2023-11-09] [$125] [Form Provider Refactor] IntroSchoolPrincipalPage

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/TeachersUnite/IntroSchoolPrincipalPage.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141a4363a42663916
• Upwork Job ID: 1716962605778067456
• Last Price Increase: 2023-10-25

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141a4363a42663916

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @alitoshmatov (Internal)

[cdOut]

Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I would like to work on this task.

[melvin-bot]

Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $125

[Samueljh1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We need to refactor Form inputs based on the new FORMS.md specification.

What is the root cause of that problem?

The current component is outdated and needs to be refactored.

What changes do you think we should make in order to solve the problem?

(From FORMS.md): All form inputs need to be wrapped in InputWrapper and passed as InputComponent property additionally it's necessary po pass an unique inputID. All other props of the input can be passed as InputWrapper props.

<InputWrapper
    // `InputWrapper` required props
    InputComponent={TextInput}
    inputID="uniqueTextInputID"
    // `TextInput` specific props
    placeholder="Text input placeholder"
    label="Text input label"
    shouldSaveDraft
/>

[luacmartins]

@Samueljh1 thanks for the proposal. We already have @cdOut working on it though

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] IntroSchoolPrincipalPage #30444

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@alitoshmatov could you work on the checklist for this one? Do we need a regression test or was this just a small change?

[alitoshmatov]

This was refactoring issue, there is no need for regression test.

[lschurr]

Great! Are you paid via Upwork @alitoshmatov? If so, can you apply here? https://www.upwork.com/jobs/~0141a4363a42663916

[alitoshmatov]

@lschurr Applied

[lschurr]

Great, offer sent!

[alitoshmatov]

Accepted

[lschurr]

Payment summary:

• @alitoshmatov $125 (paid in Upwork)