[HOLD for payment 2023-11-22] [ECARD] CRITICAL: Settings - Reveal Details Follow Up - Add Error Handling

[grgia]

Follow up from #29017 (comment)

Pending the results from marketing/design, we will update the error handling. Slack convo here: https://expensify.slack.com/archives/C027726KHT4/p1698162266272779

We will also remove this promise: #29017 (comment)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0161ba717edf2a3e86
• Upwork Job ID: 1717110115130617856
• Last Price Increase: 2023-10-25

[grgia]

cc @lukemorawski will take this one

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0161ba717edf2a3e86

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[lukemorawski]

@grgia Hey. Thanks for CC!

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

Triggered auto assignment to @NickTooker (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[grgia]

@NickTooker we need to check off the copy for this error. There's more context in this slack convo - https://expensify.slack.com/archives/C03SSAQG5/p1698224498878229

ping me if you have any questions!

[NickTooker]

An error occurred while loading the card details. Please check your internet connection and try again.

How about this? Addressing the edge case but keeping the main portion of the error message.

[joekaufmanexpensify]

That sounds good to me!

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[grgia]

Hey @dubielzyk-expensify could you mock the error state for this page?
This is the copy:

An error occurred while loading the card details. Please check your internet connection and try again.

And there's more context here: https://expensify.slack.com/archives/C027726KHT4/p1698162266272779

Figma here

Shawn proposed we follow a similar pattern to this

[grgia]

Figma link

[grgia]

@lukemorawski design has been finalized!

[grgia]

@lukemorawski could you also fix the formatting of the expiration date?

[dubielzyk-expensify]

Sorry. I didn't update this ticket, but mock provided:

Figma

[grgia]

We got the final translations today, so should be moving forward with this one. Thanks for the mocks @dubielzyk-expensify !

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Reveal card details error handling #31067

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @lukemorawski does not require payment (Contractor)

[melvin-bot]

@allroundexperts, @NickTooker, @grgia, @lukemorawski, @dubielzyk-expensify Huh... This is 4 days overdue. Who can take care of this?

[NickTooker]

@grgia Do you need me for anything else here? Thanks!

[grgia]

nope, closing! @NickTooker