Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-11-09] [ECard Settings] 🔥 Pass Last Four Digits to ActivatePhysicalExpensifyCard in Activate Card Flow #30570

Closed
grgia opened this issue Oct 30, 2023 · 5 comments
Closed

[HOLD for payment 2023-11-09] [ECard Settings] 🔥 Pass Last Four Digits to ActivatePhysicalExpensifyCard in Activate Card Flow #30570

grgia opened this issue Oct 30, 2023 · 5 comments
Assignees
@grgia
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Oct 30, 2023 •
edited by melvin-bot bot
Loading

We're not passing the last four digits to ActivatePhysicalExpensifyCard in the activate card flow. This means that this flow is broken for all users.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0109b21be9f07df2c6
  • Upwork Job ID: 1718943153615974400
  • Last Price Increase: 2023-10-30
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Oct 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0109b21be9f07df2c6

@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (Internal)

@grgia
Copy link
Contributor Author

grgia commented Oct 30, 2023

Looks the API is expecting cardLastFourDigits

@grgia grgia mentioned this issue Oct 30, 2023
Merged
62 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Oct 30, 2023
@grgia grgia assigned grgia and unassigned robertKozik Oct 30, 2023
@grgia grgia closed this as completed Nov 1, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 2, 2023
@melvin-bot melvin-bot bot changed the title [ECard Settings] 🔥 Pass Last Four Digits to ActivatePhysicalExpensifyCard in Activate Card Flow [HOLD for payment 2023-11-09] [ECard Settings] 🔥 Pass Last Four Digits to ActivatePhysicalExpensifyCard in Activate Card Flow Nov 2, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 2, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 2, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grgia grgia

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grgia @robertKozik