iOS - Request money - Green CTA button in BNP and confirmation page has different placement

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.95-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to any chat > + > Request money.
3. Enter amount and click Next.

Expected Result:

The green button at the bottom should have a consistent placement in both BNP and confirmation page

Actual Result:

The green button at the bottom does not have a consistent placement in BNP and confirmation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6262524_1699077151165.staging.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

I'm not seeing problem here...those two button LOOK consistent to me. @shawnborton are you seeing anything here? @lanitochka17 can you state a little more clearly what is not consistent and perhaps show the difference in the way the button looks on staging vs production?

Edit: is it the gap between the bottom of the button and the edge of the screen that is inconsistent?

[dannymcclain]

Posted this in Slack but might as well post it here as well: it looks like the numpad + button on the amount screen got shifted down somehow and is now too close to the bottom, which is then causing it to be in a different spot than the request button.

Screenshots for reference: Current is as of today, Previous (how it should be I believe) is from a few weeks ago (iPhone 14).

[ishpaul777]

A PR fixing this issue is just merged #30887

[joelbettner]

Very nice @ishpaul777! I see that the changes in that PR were tested for Android. Were they tested for iOS as well?

[ishpaul777]

I think yes

Double checked locally:

[joelbettner]

The changes got deployed to staging. I just tested it. All is good. I'm going to close this issue.