Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expensify.Cash - Markdown formatting removed after editing a message #3104

Closed
sakluger opened this issue May 25, 2021 · 11 comments
Closed

Expensify.Cash - Markdown formatting removed after editing a message #3104

sakluger opened this issue May 25, 2021 · 11 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2

Comments

@sakluger
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Any formatting that was added to a message via markdown should remain after the message is edited. To do this, we should show the original markdown in the "Edit message" text field and apply that markdown after saving the changes.

Actual Result:

After editing a message, all markdown formatting (such as bold, code blocks, etc) is removed. If I try to add it back, the markdown just shows as text.

Action Performed:

  1. Log into e.cash on web or on desktop
  2. Send a message to anyone with any markdown (* on each side of the text will make the text bold)
  3. Confirm that the message formatting has been applied correctly.
    image
  4. Right-click on the message you just sent and select Edit Message
    image
  5. Click Save Changes
    image
  6. Confirm that formatting has been removed
    image
  7. Edit the same message again and try adding back the original markdown
  8. Confirm that the markdown characters save as text
    image

Workaround:

The only workaround is to send a new message with the intended markdown.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App ✔️
Mobile Web

Version Number: Version 1.0.51-0
Logs: No logs
Notes/Photos/Videos: Screenshots are above in the "Action Performed" section
Expensify/Expensify Issue URL: None

View all open jobs on Upwork

@sakluger sakluger added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 25, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 25, 2021
@kakajann
Copy link
Contributor

I saw this bug before and I was going to create an issue.

Here's why this happening:

When you send message addAction function will be called and it parses the message like this

But when you edit a message editReportComment function will be called and it doesn't parse the message.

If you export this issue to upwork, I can work on this.

@MelvinBot
Copy link

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jasperhuangg jasperhuangg added AutoAssignerTriage Auto assign issues for triage to an available triage team member and removed Engineering labels May 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @SofiedeVreese (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 27, 2021
@jasperhuangg jasperhuangg added the External Added to denote the issue can be worked on by a contributor label May 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@jasperhuangg
Copy link
Contributor

Yo @MitchExpensify! @kakajann expressed interest on working on this and seems to have a solution in mind. Let me know if I need to review any proposals!

@jasperhuangg jasperhuangg added the Improvement Item broken or needs improvement. label May 27, 2021
@MitchExpensify
Copy link
Contributor

Cool, @jasperhuangg! Creating UpWork job now

@MitchExpensify
Copy link
Contributor

Here is the Job posting if you'd like to apply for it @kakajann! https://www.upwork.com/jobs/~01a7eb95dc405570e3

@MelvinBot
Copy link

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham
Copy link
Contributor

This issue is a duplicate of #2847, which is already being worked on. Closing this out! @MitchExpensify please don't hire anyone on Upwork for this.

@roryabraham
Copy link
Contributor

Also, just FYI, there is a tracking issue that this will eventually fall under here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants