[Hold for #29080] [$500] Chat - The first option in Notifications preference is always highlighted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30694

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to any chat
3. Click on the chat header
4. Click Notification preference

Expected Result:

The selected option is highlighted

Actual Result:

The first option is always highlighted
On iOS, the selected option is highlighted. The first option becomes highlighted when returning to app from the background

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269367_1699488037719.20231109_075832.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d8a2b72f459ff260
• Upwork Job ID: 1722404757021065216
• Last Price Increase: 2023-11-09

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d8a2b72f459ff260

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[abzokhattab]

Related to #29080

[wlegolas]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - The first option in Notifications preference is always highlighted

What is the root cause of that problem?

The problem is related to the BaseSelectionList component, there is an useEffect that resets the focus and scrolls to the first section when there is at least one section in the sections array.

App/src/components/SelectionList/BaseSelectionList.js

Lines 340 to 351 in dee9b31

	useEffect(() => {
	// do not change focus on the first render, as it should focus on the selected item
	if (firstLayoutRef.current) {
	return;
	}
	// set the focus on the first item when the sections list is changed
	if (sections.length > 0) {
	updateAndScrollToFocusedIndex(0);
	}
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [sections]);

The code above came through this PR #30438 related to the issue above #29080

What changes do you think we should make in order to solve the problem?

We should change this useEffect to only resets the focus and scroll to the first section when there is at least one section in the sections array and there are no selected sections.

For example,

function shouldUpdateFocusedSection(sections) {
    const availableSections = lodashGet(sections, '[0].data', []);

    return _.all(availableSections, (section) => !section.isSelected);
}

function BaseSelectionList({
  ...

    useEffect(() => {
        // do not change focus on the first render, as it should focus on the selected item
        if (firstLayoutRef.current) {
            return;
        }

        // set the focus on the first item when the sections list is changed
        if (shouldUpdateFocusedSection(sections)) {
            updateAndScrollToFocusedIndex(0);
        }
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [sections]);

    ...
});

What alternative solutions did you explore? (Optional)

The main branch already has the code with the solution from the issue above #29080, but the problem still occurring.

That's why I created this proposal.

POC

poc-issue-31087.mp4

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first option in Notifications preference is always highlighted

What is the root cause of that problem?

We change focusedIndex and scroll to the first option whenever the sections are changed. It doesn't make sense because it can be changed when the search value isn't changed.

App/src/components/SelectionList/BaseSelectionList.js

Line 349 in 5df95a1

if (sections.length > 0) {

What changes do you think we should make in order to solve the problem?

We should only scroll to the first option when both textInputValue and sections are changed.

What alternative solutions did you explore? (Optional)

[abdulrahuman5196]

Hi, Will review again today, just back from weekend

[abdulrahuman5196]

Seems there is multiple regressions from #29080 and this could be a regression as well as pointed out by contributors.

@greg-schroeder Could you kindly put this issue on hold for #29080?

[greg-schroeder]

Putting this on hold!

[greg-schroeder]

Still holding

[greg-schroeder]

same

[greg-schroeder]

""

[greg-schroeder]

Held

[greg-schroeder]

Same

[greg-schroeder]

#29080 is still open

[greg-schroeder]

held

[greg-schroeder]

29080 is deployed

[greg-schroeder]

@abdulrahuman5196 what do you think about this issue given that the hold issue is deployed? It's been a while - do we need to retest, or can we proceed?

[abdulrahuman5196]

@greg-schroeder I don't see this issue in staging. I think we can close this issue.

Screen.Recording.2024-02-27.at.1.03.52.PM.mov

[greg-schroeder]

I can't see it either, seems to be resolved. Closing!