[PAID] Implement and use ReportUtils.transactionThreadHasViolations(report)

[cead22]

• Design Doc
• Implementation should look like code snippet below
  • Which probably means we should connect ReportUtils to the BETAS onyx collection
  • Let's also connect it to the TRANSACTION_VIOLATIONS and REPORT_ACTIONS Onyx collections as shown below
  • And let's also add as shown below ReportUtils.reportHasViolations
• Then let's use ReportUtils.transactionThreadHasViolations
  • In SidebarUtils.ts Let's update this
    • From: result.brickRoadIndicator = Object.keys(result.allReportErrors ?? {}).length !== 0 ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
    • To: result.brickRoadIndicator = Object.keys(result.allReportErrors ?? {}).length !== 0 || ReportUtils.transactionThreadHasViolations(report) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
    • That way src/components/LHNOptionsList/OptionRowLHN.js should show the RBR
  • In ReportUtils.shouldReportBeInOptionList above if (isInGSDMode) { we’ll add the if in the snippet below to surface the iou reports with violations on the LHN
• And let's use ReportUtils.reportHasViolations
  • In src/components/ReportActionItem/ReportPreview.js let's update the code so the hasErrors value takes into account the report violations const hasErrors = (hasReceipts && ReportUtils.hasMissingSmartscanFields(props.iouReportID)) || ReportUtils.reportHasViolations(props.iouReportID);

const transactionViolations = {};
Onyx.connect({
    key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
    callback: (violations, key) => {
        if (!key || !violations) {
            return;
        }

        const transactionID = CollectionUtils.extractCollectionItemID(key);
        transactionViolations[transactionID] = violations;
    },
});

const reportActions = {};
Onyx.connect({
    key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
    callback: (actions, key) => {
        if (!key || !actions) {
            return;
        }

        const reportID = CollectionUtils.extractCollectionItemID(key);
        reportActions[reportID] = actions;
    },
});

function transactionThreadHasViolations(report) {
    if (!permissions.canUseViolations()) {
        return false;
    }
    if (!report.parentReportActionID ?? 0) {
        return false;
    }
    const parentReportAction = lodashGet(reportActions, `${report.parentReportID}.${report.parentReportActionID}`);
    if (!parentReportAction) {
        return false;
    }
    const transactionID = parentReportAction['originalMessage']['IOUTransactionID'] ?? 0;
    if (!transactionID) {
        return false;
    }
    const reportID = parentReportAction['originalMessage']['IOUReportID'] ?? 0;
    if (!reportID) {
        return false;
    }
    if (!isCurrentUserSubmitter(reportID)) {
        return false;
    }
    return transactionHasViolation(transactionID);
}

function transactionHasViolation(transactionID) {
    const violations = lodashGet(transactionViolations, transactionID, []);
    return _.some(violations, violation => violation.type === 'violation');
}

function reportHasViolations(reportID) {
    let transactions = TransactionUtils.getAllReportTransactions(reportID);
    return _.some(transactions, (transaction) => transactionHasViolation(transaction.transactionID));
}

// Always show IOU reports with violations
if (isExpenseRequest(report) && transactionThreadHasViolations(report)) {
    return true;
}

[cead22]

@lindboe @cdanwards can you please comment here so I can assign you?

[cdanwards]

Commenting for assignment

[melvin-bot]

@cdanwards Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cdanwards]

Beginning work on this now.

[melvin-bot]

@cdanwards Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@cdanwards Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@cdanwards 10 days overdue. I'm getting more depressed than Marvin.

[cdanwards]

Still working on this. Getting some clarification after ReportUtils got swapped to TS.

[cdanwards]

Alright there was a little trouble with converting things over to TS and solving that weird tests bug but got everything working and polishing it up for the PR!

[cead22]

Awesome! @cdanwards can you add another condition to transactionThreadHasViolations to return false if the report is on a state that isn't open or processing? We only wanna show RBR on the left hand nav to the report submitter, and only if the report is open or processing

[cdanwards]

@cead22 Definitely! I'll add that in.

[cead22]

Work in progress

[cead22]

Still a work in progress

[cead22]

@trevor-coleman can you comment here so I can assign you please?

[cead22]

PR was merged and is on staging. We found a bug that we're fixing now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.28-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Adds new ReportUtils for Violations #31448

If no regressions arise, payment will be issued on 2024-01-28. 🎊

For reference, here are some details about the assignees on this issue:

• @cdanwards does not require payment (Contractor)

[melvin-bot]

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[cead22]

@strepanier03 can you please handle payment to @situchan for the PR review, and please make it double the standard amount we pay for these. This was was a pretty complex review and this is something I offered @situchan last month to put the review at the top of the priority list. Thanks

[strepanier03]

Will do @cead22!

[strepanier03]

@situchan - An offer has been sent. I'll check later today to finish paying out and closing up.

[strepanier03]

Paid and contract closed. Thanks everyone!