Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it #31212

Closed
2 of 6 tasks
kbecciv opened this issue Nov 10, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.98.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to Settings > Workspaces > any workspace.
  3. Click Bank account.
  4. Click Connect manually.
  5. Proceed until Step 3 of bank account setup.
  6. Close the setup by clicking outside the RHN.
  7. Go to Settings > Workspaces > any workspace.
  8. Click Bank account.

Expected Result:

User will be presented with 'Continue with setup' and 'Start over' screen.

Actual Result:

User is redirected to where the bank account setup is left off.
In order to see 'Continue with setup' and 'Start over' screen, user has to return to the first screen.
On PROD, user is presented with 'Continue with setup' and 'Start over' screen after closing the setup and revisiting bank account page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271756_1699647092519.20231111_024250__1_.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 10, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johnmlee101
Copy link
Contributor

#29166 might be related

@johnmlee101
Copy link
Contributor

Asked in deployer for some extra 👀

@johnmlee101
Copy link
Contributor

Reverted it locally and it fixes it, so marking it as a regression

@johnmlee101
Copy link
Contributor

Revert PR #31214 will need to be CPd

@johnmlee101
Copy link
Contributor

fixed since the revert

@johnmlee101
Copy link
Contributor

Screen.Recording.2023-11-10.at.5.18.58.PM.mov

Copy link

melvin-bot bot commented Nov 10, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@puneetlath
Copy link
Contributor

Great! Closing this!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 14, 2023
@melvin-bot melvin-bot bot changed the title Workspace - Start over page is not shown when user quits bank account setup and revisits it [HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it Nov 14, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 14, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 15, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants