-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hold #28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header #31220
Comments
Triggered auto assignment to @laurenreidexpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~014350424b71769cdf |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
if (isWorkspaceMemberLeavingWorkspaceRoom) {
const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
const chat = ReportUtils.getChatByParticipants(participantAccountIDs);
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID));
+ } else {
+ Navigation.goBack();
+ } What alternative solutions did you explore? (Optional)
|
Should be fixed in #28997 |
@eVoloshchak do you agree this will be covered in #28997 and we can close? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@eVoloshchak bump |
@eVoloshchak I think the RCA of this issue (31220) is that we do not navigate user to the parent thread after leaving thread. The 28997 is about the behavior when we re-join the leaved thread. Both of them are not the same. Also, we are still discussing about the expected solution for 28997 |
#28997 and this issue do have different causes, but depending on which approach will be taken to fix #28997 this one might be resolved too (#28997 (comment)) @laurenreidexpensify, let's put this on HOLD for #28997 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Still on hold on #28997 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Still on hold on #28997 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Still on hold on #28997 but that has payment due on 15 Dec - so should be off hold v soon |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@eVoloshchak #28997 has been on prod for a solid 12 days now, can we lift the hold? |
@laurenreidexpensify, according to my tests, this was resolved by a fix for #28997. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@Expensify/applauseleads please confirm if this is still reproducible in KI tests |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@applausebot please confirm if this is still reproducible in KI tests |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
1 similar comment
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
I am closing based on @eVoloshchak's comment that this is resolved |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Tapping leave thread, must not display unavailable "U" for a second instead of Room name in header
Actual Result:
Tapping leave thread, displays unavailable "U" for a second instead of Room name in header.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6271878_1699653563009.u.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: