Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - User It is not redirected to New dot after logging in in Old dot #31595

Closed
1 of 6 tasks
kbecciv opened this issue Nov 20, 2023 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Nov 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31522

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Sign into NewDot with UserA
  3. Now go to OldDot and sign with some other UserB on public domain (like gmail)

Expected Result:

  1. Verify you have been redirected to NewDot
  2. Verify you are signed in as UserA

Actual Result:

User should directed to NewDot after sign with UserB in Olddot

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5480.mp4

View all open jobs on GitHub

@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 20, 2023
@melvin-bot melvin-bot bot changed the title Web - User It is not redirected to New dot after logging in in Old dot [$500] Web - User It is not redirected to New dot after logging in in Old dot Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e4653540dbdcaa94

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@erquhart
Copy link
Contributor

Is OldDot open source? Not sure this is something contributors can fix.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2023
@jliexpensify
Copy link
Contributor

@allroundexperts just going to assign you as @kbecciv is saying it's related to #31522

@jliexpensify
Copy link
Contributor

I'm also a bit confused by this issue's Actual Result - is the expectation that you should be redirected to New.Dot as User B? @kbecciv can you clarify this? The video doesn't seem to illustrate the bug.

@kbecciv
Copy link
Author

kbecciv commented Nov 21, 2023

@jliexpensify Correct, user should be diredirected to ND as a UserB, updated the video!

@jliexpensify
Copy link
Contributor

Bump @allroundexperts - might be related to your PR?

@allroundexperts
Copy link
Contributor

@jliexpensify @kbecciv I just checked and the reason why you're not being redirected is that you don't have the redirect beta enabled for your account. In order to make sure that redirect happens, you need to be logged in to OldDot using an email that ends with +classicredirect.

@allroundexperts
Copy link
Contributor

I think this issue can be safely closed.

@jliexpensify
Copy link
Contributor

Thanks for the context Sibtain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants