[HOLD for payment 2023-12-07] Personal details - Extra padding above "Address line 1" field in Address page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.2.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com.
2. Go to Settings > Profile > Personal details.
3. Click Personal details.

Expected Result:

There is no extra padding above Address line 1 field, which is the similar behavior as production and also legal name page on staging.

Actual Result:

There is extra padding above Address line 1 field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6287259_1700662497448.20231122_221209.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Personal details - Extra padding above "Address line 1" field in Address page

What is the root cause of that problem?

<View style={styles.formSpaceVertical} />
We add this code to AddressForm

App/src/components/AddressForm.js

Line 125 in 21cf959

<View style={styles.formSpaceVertical} />

What changes do you think we should make in order to solve the problem?

Let's remove

App/src/components/AddressForm.js

Line 125 in 21cf959

<View style={styles.formSpaceVertical} />

What alternative solutions did you explore? (Optional)

[DylanDylann]

@Julesssss @srikarparsi I am available to raise a quick PR for this issue

[s-alves10]

Looks like a regression of this PR #28453

[luacmartins]

Gonna demoted this to NAB since it's really small. @pac-guerreiro can you work on a fix since it seems like it came from your PR?

[pac-guerreiro]

@luacmartins yes I can!

[luacmartins]

great! thanks!

[pac-guerreiro]

@luacmartins done! #31759

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix(get physical card): bad margins affecting personal details addres… #31759

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[abdulrahuman5196]

Hi, @luacmartins / @srikarparsi Could you kindly add me as C+ here for payment processing?

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

@jliexpensify this issue was a regression from #28453. The original contributor put up a PR with a fix, but we need to compensate @abdulrahuman5196 for their review on this PR

[jliexpensify]

Payment Summary

• C+ @abdulrahuman5196 $500

Upworks Job

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Regression from #28453

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Not required IMO since its a minor change and already found part of deployment testing.

@jliexpensify

[jliexpensify]

Paid and job closed!