Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment - File upload freezes when the application is reloaded #31745

Closed
2 of 6 tasks
lanitochka17 opened this issue Nov 22, 2023 · 13 comments
Closed
2 of 6 tasks

Attachment - File upload freezes when the application is reloaded #31745

lanitochka17 opened this issue Nov 22, 2023 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open New Expensify app
  2. Disable the internet connection in the device
  3. Navigate to any conversation and upload an attachment
  4. Reload the app(CMD+R)
  5. Enable the internet connection

Expected Result:

If you upload a file offline and reload the app when you go online, the file should upload and appear in the conversation

Actual Result:

When uploading a file in offline mode and reloading the application when going online, the file is not uploaded to the conversation and the upload freezes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6287606_1700679772097.Recording__761.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 22, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 22, 2023

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link

melvin-bot bot commented Nov 22, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lanitochka17
Copy link
Author

Production:

20231123_015556.mp4

@marcaaron
Copy link
Contributor

Checking this one now...

@marcaaron
Copy link
Contributor

Open New Expensify app
Disable the internet connection in the device
Navigate to any conversation and upload an attachment
Reload the app(CMD+R)

How does this work exactly if the network is disabled for Web?

@marcaaron
Copy link
Contributor

I can't repro on main web. Checking desktop.

@marcaaron
Copy link
Contributor

Unchecked the web platforms because refreshing the page while you are offline isn't really supported.

@marcaaron marcaaron removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 22, 2023
@marcaaron marcaaron removed their assignment Nov 22, 2023
@marcaaron marcaaron added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 22, 2023
Copy link

melvin-bot bot commented Nov 22, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 22, 2023
Copy link

melvin-bot bot commented Nov 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@marcaaron
Copy link
Contributor

Can't repro on Desktop. I think this should not be a deploy blocker so gonna check it off in any case. Unclear whether it is actually an issue that needs to be fixed so sending to BZ instead of blocking deploy.

@luacmartins
Copy link
Contributor

I have a feeling that this was caused by #30425 which was reverted and CPed

@luacmartins
Copy link
Contributor

I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants