Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'WalletSection.js' component to TypeScript #31931

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 15 comments
Closed

[TS migration] Migrate 'WalletSection.js' component to TypeScript #31931

melvin-bot bot opened this issue Nov 27, 2023 · 15 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/WalletSection.js 4
Copy link
Author

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@fedirjh
Copy link
Contributor

fedirjh commented Dec 28, 2023

cc @cead22 seems like this was closed without c+ review payment.

@cead22
Copy link
Contributor

cead22 commented Dec 28, 2023

Sorry, the process wasn't clear for me

@cead22 cead22 reopened this Dec 28, 2023
@cead22 cead22 added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 28, 2023
Copy link
Author

melvin-bot bot commented Dec 28, 2023

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 28, 2023
Copy link
Author

melvin-bot bot commented Dec 28, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@cead22 cead22 added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Dec 28, 2023
Copy link
Author

melvin-bot bot commented Dec 28, 2023

Current assignee @peterdbarkerUK is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 28, 2023
@cead22
Copy link
Contributor

cead22 commented Jan 15, 2024

Bump @peterdbarkerUK

@kadiealexander kadiealexander added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Feb 1, 2024
Copy link
Author

melvin-bot bot commented Feb 1, 2024

@miljakljajic
Copy link
Contributor

Sorry @cead22 I'm not 100% clear on what the CTA is for this one? According to the SO I can decide whether or not to move this forward as a P/S or not?

@cead22
Copy link
Contributor

cead22 commented Feb 7, 2024

The CTA is to issue payment to the C+ for their review. We had closed this issue without issuing that payment, that's why I reopened and added the new feature label. Thanks

@cead22
Copy link
Contributor

cead22 commented Feb 21, 2024

There were a few reviewers of the PR but @fedirjh was the one that completed the checklist

@cead22
Copy link
Contributor

cead22 commented Mar 19, 2024

@miljakljajic bump

@miljakljajic
Copy link
Contributor

Sorry, paying!

@miljakljajic
Copy link
Contributor

@fedirjh offer is ready for you to accept when you can!

@miljakljajic
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants