Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [TS migration] Migrate 'CardPreview.js' component to TypeScript #31947

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 14 comments
Closed

[$500] [TS migration] Migrate 'CardPreview.js' component to TypeScript #31947

melvin-bot bot opened this issue Nov 27, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/CardPreview.js 10
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a76cdda5b2a6570
  • Upwork Job ID: 1738214807557545984
  • Last Price Increase: 2023-12-22
@pac-guerreiro
Copy link
Contributor

I am Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this job!

Copy link
Author

melvin-bot bot commented Dec 10, 2023

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Dec 21, 2023

PR deployed to production on Dec 14 so today is payment date.
@luacmartins can you please add Bug label and remove Reviewing? Thanks

@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 22, 2023
Copy link
Author

melvin-bot bot commented Dec 22, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 22, 2023
Copy link
Author

melvin-bot bot commented Dec 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 22, 2023
@CortneyOfstad
Copy link
Contributor

CortneyOfstad commented Dec 22, 2023

@aimane-chnaif I am assuming the only payment that has to go out is to you as the reviewer? If so, what is the amount for that? Thank you!

@aimane-chnaif
Copy link
Contributor

@CortneyOfstad right. Only me for upwork payment

@CortneyOfstad CortneyOfstad added the External Added to denote the issue can be worked on by a contributor label Dec 22, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'CardPreview.js' component to TypeScript [$500] [TS migration] Migrate 'CardPreview.js' component to TypeScript Dec 22, 2023
Copy link
Author

melvin-bot bot commented Dec 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013a76cdda5b2a6570

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 22, 2023
Copy link
Author

melvin-bot bot commented Dec 22, 2023

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

@CortneyOfstad CortneyOfstad removed Reviewing Has a PR in review Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 22, 2023
@CortneyOfstad CortneyOfstad added the Awaiting Payment Auto-added when associated PR is deployed to production label Dec 22, 2023
@ghost
Copy link

ghost commented Dec 22, 2023

I am really interested. If proposal is needed then please let me know

@Expensify Expensify deleted a comment Dec 22, 2023
@CortneyOfstad
Copy link
Contributor

@AnshuAgarwal24 the issue is already completed. Thank you for your interest though!

@CortneyOfstad
Copy link
Contributor

@aimane-chnaif The proposal for the completed job has been sent in Upwork. Please let me know when you accept so I can get that paid to you ASAP. Thanks!

@aimane-chnaif
Copy link
Contributor

Accepted. Thanks

@CortneyOfstad
Copy link
Contributor

@aimane-chnaif payment completed! Closing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants