Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-20] [TS migration] Migrate 'SettingsWalletPhysicalCard' page to TypeScript #31997

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/settings/Wallet/Card/GetPhysicalCardPhone.js 14
src/pages/settings/Wallet/Card/GetPhysicalCardName.js 13
src/pages/settings/Wallet/Card/GetPhysicalCardConfirm.js 15
src/pages/settings/Wallet/Card/GetPhysicalCardAddress.js 10
src/pages/settings/Wallet/Card/BaseGetPhysicalCard.js 19
@pasyukevich
Copy link
Contributor

Hi,
I'm Eugene from Callstack - an expert contributor group
I’d like to work on this issue

@melvin-bot melvin-bot bot added Overdue Monthly KSv2 and removed Weekly KSv2 labels Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Jan 29, 2024

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 9, 2024
Copy link
Author

melvin-bot bot commented Feb 9, 2024

@amyevans
Copy link
Contributor

amyevans commented Feb 9, 2024

Assigned @situchan since they reviewed the PR

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 13, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SettingsWalletPhysicalCard' page to TypeScript [HOLD for payment 2024-02-20] [TS migration] Migrate 'SettingsWalletPhysicalCard' page to TypeScript Feb 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 13, 2024
Copy link
Author

melvin-bot bot commented Feb 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Feb 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @pasyukevich does not require payment (Contractor)
  • @situchan requires payment (Needs manual offer from BZ)

Copy link
Author

melvin-bot bot commented Feb 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 20, 2024
Copy link
Author

melvin-bot bot commented Feb 20, 2024

Payment Summary

Upwork Job

BugZero Checklist (@johncschuster)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@johncschuster
Copy link
Contributor

@situchan, I've extended an offer for the job, here. Can you accept that? Thanks!

@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
Copy link
Author

melvin-bot bot commented Feb 26, 2024

@johncschuster, @amyevans, @pasyukevich, @situchan Eep! 4 days overdue now. Issues have feelings too...

@johncschuster
Copy link
Contributor

Payment has been issued! 🎉 Thanks,everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants