Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #32004

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 40 comments
Closed

[$250] [TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #32004

melvin-bot bot opened this issue Nov 27, 2023 · 40 comments
Assignees
@Julesssss @kevinksullivan @neonbhai @ishpaul777
Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023 •
edited by Julesssss
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/iou/MoneyRequestTagPage.js 20
src/pages/iou/MoneyRequestSelectorPage.js 28
src/pages/iou/MoneyRequestMerchantPage.js 20
src/pages/iou/MoneyRequestDescriptionPage.js 23
src/pages/iou/MoneyRequestDatePage.js 18
src/pages/iou/MoneyRequestCategoryPage.js 17
src/pages/iou/steps/MoneyRequestConfirmPage.js 30
src/pages/iou/steps/MoneyRequestAmountForm.js 19
src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js 22
src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js 23
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015f651a06a6589036
  • Upwork Job ID: 1744724774144225280
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • neonbhai | Contributor | 28092407
    • ishpaul777 | Contributor | 28142235
Issue OwnerCurrent Issue Owner: @kevinksullivan
Issue OwnerCurrent Issue Owner: @kevinksullivan
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels Jan 9, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'IOUMoneyRequest' page to TypeScript [$500] [TS migration] Migrate 'IOUMoneyRequest' page to TypeScript Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to @kevinksullivan (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015f651a06a6589036

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Monthly KSv2 labels Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'IOUMoneyRequest' page to TypeScript [$250] [TS migration] Migrate 'IOUMoneyRequest' page to TypeScript Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Upwork job price has been updated to $250

@tienifr
Copy link
Contributor

tienifr commented Jan 9, 2024

Would love to work on it

@HezekielT
Copy link
Contributor

I'd like to work on this.

@rayane-djouah
Copy link
Contributor

I would like to work on this

@s-alves10
Copy link
Contributor

Would love to work on it

@vadymbokatov
Copy link
Contributor

Hi I would like to work on this please.

@yh-0218
Copy link
Contributor

yh-0218 commented Jan 9, 2024

I'd like to work on it.

@shahinyan11
Copy link

I would like to work on this

@ghost
Copy link

ghost commented Jan 9, 2024

Dibs

@neonbhai
Copy link
Contributor

neonbhai commented Jan 29, 2024 •
edited
Loading

Raising final PR EOD!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 29, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 2, 2024

@eVoloshchak, @Julesssss, @kevinksullivan, @neonbhai Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Julesssss
Copy link
Contributor

Hey @neonbhai, is there a PR ready? I can't find it. Thanks!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 2, 2024
@neonbhai neonbhai mentioned this issue Feb 4, 2024
Merged
49 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Feb 4, 2024
@Julesssss Julesssss assigned ishpaul777 and unassigned eVoloshchak Feb 5, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 5, 2024

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 21, 2024
@ishpaul777
Copy link
Contributor

@kevinksullivan This should be ready for payment. PR deployed to prod 2 weeks ago..

@ishpaul777
Copy link
Contributor

@Julesssss @kevinksullivan friendly bump 🙂

@neonbhai
Copy link
Contributor

@Julesssss @kevinksullivan gentle bump for processing the payments 😅

@Julesssss
Copy link
Contributor

I'll dm @kevinksullivan, but please tag us again if this doesn't get resolved by the end of the week 👍

@kevinksullivan
Copy link
Contributor

@ishpaul777 offer sent. @neonbhai I believe I sent you an offer just now, but I am not seeing it tied to this specific job. Do you see a new offer?

@neonbhai
Copy link
Contributor

@kevinksullivan yes, I've accepted the new offer

@kevinksullivan
Copy link
Contributor

thanks @neonbhai , paid.

@ishpaul777
Copy link
Contributor

Can we please hold the payment for few days,I have applied GSTIN which will take few days otherwise upwork keeps charging me extra 💰 https://support.upwork.com/hc/en-us/articles/360041114713-India-GST-for-freelancers

@ishpaul777
Copy link
Contributor

hi @kevinksullivan, Thanks for holding i have accepted the offer

@Julesssss
Copy link
Contributor

@kevinksullivan ready for payment now 👍

@kevinksullivan
Copy link
Contributor

all set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

@kevinksullivan kevinksullivan

@neonbhai neonbhai

@ishpaul777 ishpaul777

Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests