Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS migration] Migrate 'getIsUsingFakeTimers.js' test to TypeScript #32008

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 5 comments
Closed

[TS migration] Migrate 'getIsUsingFakeTimers.js' test to TypeScript #32008

melvin-bot bot opened this issue Nov 27, 2023 · 5 comments
Labels
Monthly KSv2 Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/utils/getIsUsingFakeTimers.js 0
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 21, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 21, 2023
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2024
@JKobrynski JKobrynski mentioned this issue Mar 1, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Monthly KSv2 labels Mar 7, 2024
@JKobrynski
Copy link
Contributor

The PR is ready for review!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 5, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Apr 5, 2024

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@blazejkustra
Copy link
Contributor

We can close this issue, PR was merged a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Monthly KSv2 Reviewing Has a PR in review Task Typescript Migration
Projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JKobrynski @blazejkustra @roryabraham